fix: add type guard in process_config for non-dict input#4618
Open
Anandesh-Sharma wants to merge 1 commit intocrewAIInc:mainfrom
Open
fix: add type guard in process_config for non-dict input#4618Anandesh-Sharma wants to merge 1 commit intocrewAIInc:mainfrom
Anandesh-Sharma wants to merge 1 commit intocrewAIInc:mainfrom
Conversation
When Pydantic's `mode='before'` validator passes raw input to `process_config`, the `values` parameter may not be a dict (e.g., when `Task(agent="string")` is used). This causes an `AttributeError` on `values.get()`. Adding a type guard returns non-dict values unchanged, letting Pydantic's own type validation produce a proper ValidationError. Fixes crewAIInc#4419 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
process_config()to handle non-dict input gracefullyTask(agent="string")is passed, Pydantic'smode='before'validator forwards the raw string toprocess_config(), which calls.get()on it, causing anAttributeErrorValidationErrorFixes #4419
Test plan
Task(agent="string")raises a clear PydanticValidationErrorinstead ofAttributeErrorTask(agent=Agent(...))continues to work as expected🤖 Generated with Claude Code