fix: MCP tools not loading when tools is None#4587
Open
thakoreh wants to merge 1 commit intocrewAIInc:mainfrom
Open
fix: MCP tools not loading when tools is None#4587thakoreh wants to merge 1 commit intocrewAIInc:mainfrom
thakoreh wants to merge 1 commit intocrewAIInc:mainfrom
Conversation
|
You have run out of free Bugbot PR reviews for this billing cycle. This will reset on February 28. To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial. |
Contributor
|
Please remove the context window management logic from this pr and install pre-commit hooks |
0992490 to
e380023
Compare
Author
|
Thanks for the feedback @greysonlalonde! I've cleaned up this PR:
The pre-commit hooks are already configured in the repo ( |
Fixes crewAIInc#4568 When using the parameter without setting , the MCP tools were not being loaded because the code checked . This means users who only want to use MCP tools (without any other tools) couldn't do so. Solution: Initialize to an empty list when it's None and MCP/platform tools are provided.
e380023 to
00bf7f8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4568 - When I use mcps but tools is None, it will not load mcp tools
Problem
When using the
mcpsparameter without settingtools, the MCP tools were not being loaded because the code checked:This means users who only want to use MCP tools (without any other tools) couldn't do so.
Solution
Initialize
self.toolsto an empty list when it's None and MCP/platform tools are provided:Changes
lib/crewai/src/crewai/agent/core.pyto initializeself.tools = []when None and tools need to be addedTesting
Now this works: