Skip to content

fix(telemetry): skip signal registration on non-main threads #4394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thecaptain789 wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −0
Open

fix(telemetry): skip signal registration on non-main threads #4394

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions lib/crewai/src/crewai/telemetry/telemetry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,13 @@ def _register_shutdown_handlers(self) -> None:

self._original_handlers: dict[int, Any] = {}

# Signal handlers can only be registered from the main thread
if threading.current_thread() is not threading.main_thread():
logger.debug(
"Skipping signal handler registration (not running in main thread)"
)
return

self._register_signal_handler(signal.SIGTERM, SigTermEvent, shutdown=True)
self._register_signal_handler(signal.SIGINT, SigIntEvent, shutdown=True)
if hasattr(signal, "SIGHUP"):
Expand Down
Loading