fix: ensure TaskOutput.pydantic is populated on first guardrail invocation#4370
Open
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Open
fix: ensure TaskOutput.pydantic is populated on first guardrail invocation#4370devin-ai-integration[bot] wants to merge 1 commit intomainfrom
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Conversation
…ation Previously, when a task had guardrails configured, _export_output() was intentionally skipped on the first attempt, causing TaskOutput.pydantic and TaskOutput.json_dict to be None. This made it difficult to write guardrail functions that need to access the structured Pydantic output. This fix removes the conditional skip of _export_output() in both _execute_core() and _aexecute_core(), ensuring consistent behavior across all guardrail invocations. Fixes #4369 Co-Authored-By: João <joao@crewai.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: ensure TaskOutput.pydantic is populated on first guardrail invocation
Summary
Fixes #4369 where
TaskOutput.pydanticandTaskOutput.json_dictwereNoneon the first guardrail invocation but correctly parsed on retry attempts.The root cause was that
_export_output()was intentionally skipped when guardrails were present on the first attempt. This fix removes that conditional skip in both_execute_core()(sync) and_aexecute_core()(async), ensuring consistent behavior across all guardrail invocations.Before: Guardrail functions received
TaskOutputwithpydantic=Noneon first callAfter: Guardrail functions receive properly parsed
TaskOutput.pydanticon all callsReview & Testing Checklist for Human
_aexecute_core) works correctly with guardrails - the new tests only cover sync execution_export_output()when guardrails existSuggested test plan:
Notes