fix: skip signal handler registration in non-main thread#4296
Open
Bharath-designer wants to merge 1 commit intocrewAIInc:mainfrom
Open
fix: skip signal handler registration in non-main thread#4296Bharath-designer wants to merge 1 commit intocrewAIInc:mainfrom
Bharath-designer wants to merge 1 commit intocrewAIInc:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve telemetry behavior when initialized from non-main threads.
Fixes: #4289
Note
Improve telemetry robustness in threaded contexts
telemetry._register_shutdown_handlersto detect non‑main threads and skip calling'_register_signal_handler'; logs a debug message mentioningCREWAI_DISABLE_TELEMETRY=trueand linking tohttps://docs.crewai.com/telemetryto avoid noisyValueErrortracebacks.tests/telemetry/test_telemetry.pycovering: skip on non‑main thread (noValueError), presence of the debug log message, and that main thread still registers handlers; minor test import adjustment.Written by Cursor Bugbot for commit b43b989. This will update automatically on new commits. Configure here.