fix: Make TaskEvaluation.quality optional with default value #3917
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
TaskEvaluation Pydantic validation fails when LLM streaming responses omit the required
qualityfield, causing memory save failures. This matches the issue described in #3915.Solution
qualityfield optional with default value of 5.0Testing
Impact
Fixes #3915
Note
Set a 5.0 default for TaskEvaluation.quality, tighten the evaluation prompt requirements, and add tests covering missing/provided quality and JSON parsing.
TaskEvaluation: setqualitydefault to5.0and update its description.TaskEvaluator.evaluate: require ALL fields; emphasize numeric, requiredqualityscore in instructions.qualitywhen omitted, handling when provided, andmodel_validate_jsonwith partial JSON; update imports accordingly.Written by Cursor Bugbot for commit 5d1f444. This will update automatically on new commits. Configure here.