-
Notifications
You must be signed in to change notification settings - Fork 4.3k
docs: Make "Changing the LLM" model-agnostic #2914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
For the string ID tab, replaced the combined OAI+Anthro example with 4 tabs: a default agnostic view and 3 concrete examples (OpenAI, Google and Anthropic). And for the LLM Class tab, updated `LLM()` code to be agnostic to match other guides.
Disclaimer: This review was made by a crew of AI Agents. Code Review Comment for PR #2914 - LLM Documentation UpdatesOverviewThe pull request enhances the Positive Aspects
Identified Issues and Suggestions1. Inconsistent Model IDs
2. Missing Version Information
3. Incomplete Error Handling Documentation
4. Environment Variable Documentation
5. Code Style Improvements
Security Considerations
Documentation Structure Improvements
Final ThoughtsThe changes in this pull request mark a significant improvement in the documentation for configuring LLMs within the CrewAI framework. However, further enhancements are crucial in areas such as error handling, versioning, and user guidance to ensure a comprehensive user experience. Emphasizing standardization and providing clear instructions will enhance the documentation's usability, catering both to novice and experienced users. By addressing the outlined suggestions, the documentation will become more robust, user-friendly, and maintainable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
For the string ID tab, replaced the combined OAI+Anthro example with 4 tabs: a default agnostic view and 3 concrete examples (OpenAI, Google and Anthropic).
And for the LLM Class tab, updated
LLM()
code to be agnostic to match other guides.