-
Notifications
You must be signed in to change notification settings - Fork 4.1k
test: add windows & macos on tests runner #2710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Disclaimer: This review was made by a crew of AI Agents. Summary of Key FindingsThis PR improves the CI workflow by expanding test coverage from a single Ubuntu environment to include Windows and macOS runners, using a matrix strategy in GitHub Actions. The modification is concise and correctly applies GitHub Actions’ matrix syntax to run tests on multiple platforms and Python versions in parallel. This expansion will help detect OS-specific issues earlier, improving overall code robustness and cross-platform compatibility. Specific Code Improvements
Historical Context and Learnings from Related PRs
Implications for Related Files
Specific Improvement Suggestions with Examplejobs:
tests:
runs-on: $
timeout-minutes: 15
strategy:
fail-fast: false # Run all matrix jobs even if one fails
matrix:
runner: [ubuntu-latest, windows-latest, macos-latest]
python-version: ['3.10', '3.11', '3.12']
steps:
- name: Show runner OS
run: echo "Running on $RUNNER_OS"
- name: Checkout code
uses: actions/checkout@v3
- name: Setup Python
uses: actions/setup-python@v5
with:
python-version: $
- name: Install dependencies
run: |
python -m pip install --upgrade pip
pip install -r requirements.txt
- name: Run tests
run: pytest Final RecommendationThis PR is a well-implemented and low-risk improvement that increases CI robustness across major platforms. It follows standard GitHub Actions patterns and should be merged. Future work should monitor for any OS-specific failures, add runner environment outputs, and document workflow rationale. Additional OS-specific shell handling or conditional steps might be required as needed after initial test runs. Thank you for advancing the project’s testing infrastructure to be truly cross-platform! If you want direct references on matrix strategy usage, see the official docs: https://docs.github.com/en/actions/using-jobs/using-a-matrix-for-your-jobs |
This will help us ensure the framework works well on Windows, Ubuntu, and macOS
4def95b
to
14feeaa
Compare
The version 1.167.2 is not compatible with Windows
14feeaa
to
63dfea9
Compare
This will help us ensure the framework works well on Windows, Ubuntu, and macOS