Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the NGC service. #143

Merged
merged 5 commits into from
Jul 24, 2023
Merged

Fix the NGC service. #143

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
eee868c
Add conda binaries to the end of the path in NGC images.
veritas9872 Jun 19, 2023
748652d
Unify variable representation to ${PATH}.
veritas9872 Jun 19, 2023
5f87f5b
Add gdb and lldb to ngc requirements for easier use in CLion.
veritas9872 Jun 19, 2023
2fde6da
Merge branch 'main' into dev/ngc-path
veritas9872 Jul 23, 2023
5ab1000
Fix the PYTHONPATH bug in the NGC image.
veritas9872 Jul 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Unify variable representation to ${PATH}.
  • Loading branch information
@veritas9872
veritas9872 committed Jun 19, 2023
commit 748652de3b6d26df71e2b9525a9230b832bd46c0
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ ENV MALLOC_CONF=background_thread:true,metadata_thp:auto,dirty_decay_ms:30000,mu
# https://docs.docker.com/engine/reference/commandline/dockerd/#daemon-configuration-file
# https://github.com/docker/cli/issues/2325
WORKDIR /opt/ccache
ENV PATH=/opt/conda/bin/ccache:$PATH
ENV PATH=/opt/conda/bin/ccache:${PATH}
# Enable `ccache` with unlimited memory size for faster builds.
RUN ccache --set-config=cache_dir=/opt/ccache && ccache --max-size 0

Expand Down
2 changes: 1 addition & 1 deletion dockerfiles/hub.Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ RUN --mount=type=bind,from=stash,source=/tmp/apt,target=/tmp/apt \
xargs -r apt-get install -y --no-install-recommends && \
rm -rf /var/lib/apt/lists/*

# `/opt/conda/bin` is expected to be on the $PATH already.
# `/opt/conda/bin` is expected to be on the ${PATH} already.
ARG PIP_CACHE_DIR=/root/.cache/pip
ARG CONDA_PKGS_DIRS=/opt/conda/pkgs
# `conda` is intentionally left as a `root` directory.
Expand Down
4 changes: 2 additions & 2 deletions dockerfiles/simple.Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ ENV PYTHONIOENCODING=UTF-8
ARG PYTHONDONTWRITEBYTECODE=1
ARG PYTHONUNBUFFERED=1

ARG PATH=/opt/conda/bin:$PATH
ARG PATH=/opt/conda/bin:${PATH}

# `CONDA_MANAGER` may be either `mamba` or `conda`.
ARG CONDA_MANAGER
Expand Down Expand Up @@ -101,7 +101,7 @@ ENV PYTHONIOENCODING=UTF-8
ARG PYTHONDONTWRITEBYTECODE=1
ARG PYTHONUNBUFFERED=1

ARG PATH=/opt/_conda/bin:$PATH
ARG PATH=/opt/_conda/bin:${PATH}
COPY --link --from=lock-stash /opt/_conda /opt/_conda
COPY --link ../reqs/simple.conda-lock.yaml /tmp/conda/lock.yaml
# Saves to `conda-linux-64.lock`, which can be installed via `conda create`.
Expand Down