test: add tests for new DEX #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
since pool's current liquidity will always be positive, it has same effect to use AmountDelta
use custom `PriceToBytes` instead of `sdk.SortableDecBytes`
also add new store iteration method
comparing open quantity with zero was not enough to check if the order was fully executed, the ideal solution would be using `ExecutableQuantity`
allow negative farmingRewardsGrowthInside, like feeGrowthInside
…t into new-dex-tests
kingcre
requested review from
crypin,
richard-bachman and
lv-koala
as code owners
|
this failed lint part If you put sanity check because there is no possibility of this part occurring, why don't you panic it so that you can check the occurrence with simulation, fuzzing, etc. before going to production? |
crypin
reviewed
Jul 12, 2023
This is being discussed separately. Another PR will resolve this issue later. |
crypin
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The purpose of this PR is to increase test coverage.
Tasks