Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add flag to disable events that occur during v5 upgrade, migration #162

Merged
merged 2 commits into from
Jun 23, 2023

Conversation

crypin
Copy link
Member

@crypin crypin commented Jun 23, 2023

Description

During this v5 upgrade and migration, a large number of events could be emited, and the possibility of stability issues in some nodes was confirmed, so a flag that can be used at this time was added

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Appropriate labels applied
  • Targeted PR against correct branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@crypin crypin marked this pull request as ready for review June 23, 2023 01:02
@crypin crypin merged commit 8ac6534 into amm-module Jun 23, 2023
@kingcre kingcre deleted the amm-module-migration-event-emit-poc branch August 1, 2023 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants