Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix incorrect rewards value for RewardsAuction #103

Merged
merged 1 commit into from
Nov 14, 2022
Merged

fix: fix incorrect rewards value for RewardsAuction #103

merged 1 commit into from
Nov 14, 2022

Conversation

queencre
Copy link
Contributor

@queencre queencre commented Nov 10, 2022 •
edited
Loading

Description

closes: #102

Tasks

  • Calculate total rewards by adding currently accumulated farming rewards with withdrawn rewards reserves
  • Add test case to verify

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Appropriate labels applied
  • Targeted PR against correct branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@queencre queencre self-assigned this Nov 10, 2022
@queencre queencre marked this pull request as ready for review November 10, 2022 04:54
richard-bachman
richard-bachman reviewed Nov 10, 2022
View reviewed changes
Copy link
Member

@richard-bachman richard-bachman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the update. I left one comment.

kingcre
kingcre approved these changes Nov 11, 2022
View reviewed changes
Copy link
Contributor

@kingcre kingcre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@queencre queencre merged commit 80b4308 into crescent-network:main Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richard-bachman richard-bachman richard-bachman left review comments

@kingcre kingcre kingcre approved these changes

@crypin crypin Awaiting requested review from crypin crypin is a code owner

Assignees

@queencre queencre

Labels
x/liquidfarming
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix incorrect rewards value for RewardsAuction
3 participants
@queencre @kingcre @richard-bachman