Skip to content

Comments

Remove UNSAFE_componentWillUpdate#20

Open
nathanharper wants to merge 1 commit intocrello:masterfrom
nathanharper:remove-UNSAFE_componentWillUpdate
Open

Remove UNSAFE_componentWillUpdate#20
nathanharper wants to merge 1 commit intocrello:masterfrom
nathanharper:remove-UNSAFE_componentWillUpdate

Conversation

@nathanharper
Copy link

fixes React.StrictMode errors

fixes React.STrictMode errors
@nathanharper nathanharper changed the title move willUpdate logic to didUpdate Remove UNSAFE_componentWillUpdate May 29, 2020
@nathanharper nathanharper force-pushed the remove-UNSAFE_componentWillUpdate branch from 6c7be4c to 2e4de7b Compare June 9, 2020 10:23
@emjimadhu
Copy link

Hi what happened to this PR?

@nathanharper
Copy link
Author

@emjimadhu I haven't heard anything about it 🤷‍♂️

@flikQ
Copy link

flikQ commented Apr 8, 2021

Merge please!

@nathanharper
Copy link
Author

@sarmad1995 can you merge this if it looks ok? seems it can only be merged by somebody with write access.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants