Automatically accept TOU #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FokkeZB
commented
Jun 16, 2023
| @@ -509,7 +565,7 @@ private struct LibreLinkResponseGlucose: Codable { | |||
| // MARK: - LibreLinkResponseUser | |||
|
|
|||
| private struct LibreLinkResponseUser: Codable { | |||
| let id: String | |||
There was a problem hiding this comment.
When prompted for terms, the id is missing.
| @@ -188,7 +188,20 @@ class LibreLinkUpConnection: SensorBluetoothConnection, IsSensor { | |||
| if lastLogin == nil || lastLogin!.authExpires <= Date() { | |||
| DirectLog.info("LibreLinkUp processLogin, starts working, \(Date().debugDescription)") | |||
|
|
|||
| let loginResponse = try await login(apiRegion: apiRegion) | |||
| var loginResponse = try await login(apiRegion: apiRegion) | |||
| if loginResponse.status == 4 { | |||
There was a problem hiding this comment.
AFAIK a status of 4 means we need to accept terms. I could also type the step object so that I could do loginResponse.data.step.type == "tou" here, but this works.
| throw LibreLinkError.missingUserOrToken | ||
| } | ||
|
|
||
| loginResponse = try await tou(apiRegion: apiRegion, authToken: authToken) |
There was a problem hiding this comment.
We do need the token.
| if let apiRegion = apiRegion { | ||
| urlString = "https://api-\(apiRegion).libreview.io/auth/continue/tou" | ||
| } else { | ||
| urlString = "https://api.libreview.io/auth/continue/tou" |
There was a problem hiding this comment.
All we need is a POST to this endpoint, and pass along the token.
| DirectLog.info("LibreLinkUp tou, response: \(String(data: data, encoding: String.Encoding.utf8))") | ||
|
|
||
| if statusCode == 200 { | ||
| return try decode(LibreLinkResponse<LibreLinkResponseLogin>.self, data: data) |
There was a problem hiding this comment.
The response is identical to login.
|
Thank you so much <3, I haven't had enough time the last few months, I'll have a look at the PR. I will do that in the next few days. Many greetings |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes, login can ask to accept terms, and will not return the user ID we need, nor respond to later requests for data until the terms have been accepted.
This PR handles that by automatically accepting the terms.
Closes #452