-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Since we do not like some of the default golint rules, this commit proposes to use https://github.com/mgechev/revive. And potential revive speed-up should't hurt :). Right now, presented config (./conf/revive.toml) is permissive, we might improve it over time however. Fixes for found revive issues in the code are very limited so it wouldn't be large to review. Also in this commit: * Add annotations for makefile commands and declare phony targets * Rename "gometalinter" script and CI command to "lint" since we are doing there a bit more then using gometalinter package * Add Makefile rules to .editorconfig * Documentation which mentioned "golint" replaced with revive Fixes #16109 Ref #16160
- Loading branch information
Showing
10 changed files
with
110 additions
and
27 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
ignoreGeneratedHeader = false | ||
severity = "error" | ||
confidence = 0.8 | ||
errorCode = 0 | ||
|
||
[rule.context-as-argument] | ||
[rule.error-return] | ||
[rule.package-comments] | ||
[rule.range] | ||
[rule.superfluous-else] | ||
[rule.modifies-parameter] | ||
|
||
# This can be checked by other tools like megacheck | ||
[rule.unreachable-code] | ||
|
||
# Those are probably should be enabled at some point | ||
# [rule.unexported-return] | ||
# [rule.exported] | ||
# [rule.var-naming] | ||
# [error-naming] | ||
# [rule.dot-imports] | ||
# [blank-imports] | ||
# [rule.receiver-naming] | ||
# [error-strings] | ||
# [rule.if-return] | ||
# [rule.indent-error-flow] | ||
# [rule.blank-imports] |
Empty file.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
name: "grafana" | ||
arch: "${ARCH}" | ||
platform: "linux" | ||
version: "${VERSION}" | ||
section: "default" | ||
priority: "extra" | ||
replaces: | ||
- grafana | ||
provides: | ||
- grafana-server | ||
- grafana-cli | ||
depends: | ||
- adduser | ||
- libfontconfig | ||
maintainer: "<contact@grafana.com>" | ||
description: | | ||
Grafana | ||
vendor: "Grafana" | ||
homepage: "https://grafana.com" | ||
license: "Apache 2" | ||
bindir: "/usr/sbin" | ||
files: | ||
"./bin/grafana-server": "/usr/sbin/grafana-server" | ||
"./bin/grafana-cli": "/usr/sbin/grafana-cli" | ||
config_files: | ||
./packaging/deb/init.d/grafana-server: "/etc/init.d/grafana-server" | ||
./packaging/deb/default/grafana-server: "/etc/default/grafana-server" | ||
./packaging/deb/systemd/grafana-server.service: "/usr/lib/systemd/system/grafana-server.service" | ||
overrides: | ||
rpm: | ||
scripts: | ||
preinstall: ./scripts/preinstall.sh | ||
postremove: ./scripts/postremove.sh | ||
deb: | ||
scripts: | ||
postinstall: ./packaging/deb/control/postinst |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters