Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Tailwind to 2.0 #5

Closed
wants to merge 3 commits into from

Conversation

tuomohopia
Copy link

Upgrades Tailwind to 2.0 according to the official instructions: https://tailwindcss.com/docs/upgrading-to-v2

The only part I wasn't sure about is configuring the color palette: https://tailwindcss.com/docs/upgrading-to-v2#configure-your-color-palette-explicitly

However, as far as I can tell, everything works as before.

@einazare
Copy link
Contributor

Hello @tuomohopia ,

We'll take a look at your PR in a couple of days. If it's ok, we'll add it to out dev-main branch.

Best,
Manu

800: '#9b2c2c',
900: '#742a2a',
},
orange: {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @tuomohopia

Please delete the orange color object. These are from Tailwind v1, but we would like when we update to Tailwind v2, we would like to have their new colors: https://tailwindcss.com/docs/customizing-colors#color-palette-reference

Will wait for these changes. As soon as you do them, we'll approve your PR.

Best,
Manu

800: '#2d3748',
900: '#1a202c',
},
red: {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @tuomohopia

Please delete this color object. These are from Tailwind v1, but we would like when we update to Tailwind v2, we would like to have their new colors: https://tailwindcss.com/docs/customizing-colors#color-palette-reference

Will wait for these changes. As soon as you do them, we'll approve your PR.

Best,
Manu

black: '#000',
white: '#fff',

gray: {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @tuomohopia

Please delete this color object. These are from Tailwind v1, but we would like when we update to Tailwind v2, we would like to have their new colors: https://tailwindcss.com/docs/customizing-colors#color-palette-reference

Will wait for these changes. As soon as you do them, we'll approve your PR.

Best,
Manu

800: '#9c4221',
900: '#7b341e',
},
yellow: {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @tuomohopia

Please delete this color object. These are from Tailwind v1, but we would like when we update to Tailwind v2, we would like to have their new colors: https://tailwindcss.com/docs/customizing-colors#color-palette-reference

Will wait for these changes. As soon as you do them, we'll approve your PR.

Best,
Manu

800: '#975a16',
900: '#744210',
},
green: {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @tuomohopia

Please delete this color object. These are from Tailwind v1, but we would like when we update to Tailwind v2, we would like to have their new colors: https://tailwindcss.com/docs/customizing-colors#color-palette-reference

Will wait for these changes. As soon as you do them, we'll approve your PR.

Best,
Manu

800: '#276749',
900: '#22543d',
},
teal: {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @tuomohopia

Please delete this color object. These are from Tailwind v1, but we would like when we update to Tailwind v2, we would like to have their new colors: https://tailwindcss.com/docs/customizing-colors#color-palette-reference

Will wait for these changes. As soon as you do them, we'll approve your PR.

Best,
Manu

800: '#285e61',
900: '#234e52',
},
blue: {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @tuomohopia

Please delete this color object. These are from Tailwind v1, but we would like when we update to Tailwind v2, we would like to have their new colors: https://tailwindcss.com/docs/customizing-colors#color-palette-reference

Will wait for these changes. As soon as you do them, we'll approve your PR.

Best,
Manu

800: '#2c5282',
900: '#2a4365',
},
indigo: {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @tuomohopia

Please delete this color object. These are from Tailwind v1, but we would like when we update to Tailwind v2, we would like to have their new colors: https://tailwindcss.com/docs/customizing-colors#color-palette-reference

Will wait for these changes. As soon as you do them, we'll approve your PR.

Best,
Manu

800: '#434190',
900: '#3c366b',
},
purple: {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @tuomohopia

Please delete this color object. These are from Tailwind v1, but we would like when we update to Tailwind v2, we would like to have their new colors: https://tailwindcss.com/docs/customizing-colors#color-palette-reference

Will wait for these changes. As soon as you do them, we'll approve your PR.

Best,
Manu

800: '#553c9a',
900: '#44337a',
},
pink: {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @tuomohopia

Please delete this color object. These are from Tailwind v1, but we would like when we update to Tailwind v2, we would like to have their new colors: https://tailwindcss.com/docs/customizing-colors#color-palette-reference

Will wait for these changes. As soon as you do them, we'll approve your PR.

Best,
Manu

Base automatically changed from master to main March 17, 2021 11:31
@einazare
Copy link
Contributor

This PR was closed since the modifications were not implemented - note, in a few days we'll release a new version of the product with Tailwind v2

@einazare einazare closed this Mar 17, 2021
einazare added a commit that referenced this pull request Mar 18, 2021
Closes #4
Closes #5
Closes #6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants