Skip to content

(WIP)feat(frontend): add to favorites#836

Open
CarmenPopoviciu wants to merge 3 commits intomasterfrom
frontend/star
Open

(WIP)feat(frontend): add to favorites#836
CarmenPopoviciu wants to merge 3 commits intomasterfrom
frontend/star

Conversation

@CarmenPopoviciu
Copy link
Contributor

No description provided.

this commit adds a very basic ExpansionPanel UI widget, based on angular Material's `<mat-expansion-panel>`. The component can be used in a YAML pipeline as follows:

```
 -
   component: ExpansionPanel
   attributes:
       title: "Title"
       description: "Description"
  children:
      -
        ....
```
@teropa
Copy link
Contributor

teropa commented Dec 5, 2017

From a quick glance LGTM.... in theory what you could do to hook up the backend semi-quickly:

  1. Create a SelectionControl (or something like that) python widget, that can receive selected items from the frontend.
  2. Add a SelectionControl to the display and hook it up to the grid frontend component using the multi-connect API. So that whenever the user favorites a thing, the SelectionControl returns that thing.
  3. Make another Buffer for all the selected layouts. It pulls from the SelectionControl.
  4. Pull the Buffer into the carousel

@teropa
Copy link
Contributor

teropa commented Mar 5, 2018

@CarmenPopoviciu Shall we close this? We've gone pretty far in the past three months :)

@CarmenPopoviciu
Copy link
Contributor Author

if @MiguelNicolau thinks we don't want this kind of feature in the future, then yeah, we should

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants