Open
Conversation
Contributor
|
@andrei-antal can you pls squash these commits into one, if possible. It would make my rebase attempt much easier <3 |
feat(entity-delete): update list pipeline for actions and pass the action to the delete blocks feat(entity-delete): Remove stand alone reference pipelines feat(entity-delete): Refactor frontend code: pass the entity to the EntityComponent and hadle decomposition in that component feat(entity-delete): Refactor pipe code, comment flatMap section as it blocks the create flow feat(entity-delete): update formatting
andrei-antal
force-pushed
the
feat/delete-entity
branch
from
20ac4c5 to
144c99a
Compare
Contributor
|
Cool! The storage blocks have been switched from in-memory to postgres just now. Perhaps good to have a word with @leshy on getting the delete operation covered as well |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Delete entity functionality (partial)
actionproperty of theEntityListblock and will render in the interface as buttonsEntityandEntityList- now the whole entity is passed down from the list, and data decomposition is handled in the entity component. When actions are triggered, the whole entity is passed up to the parentDeleteEntityblockproduct-listpipelineNOTE: ATM delete does not refresh the entity list on the fronted, although the delete is indeed executed. So whenever a delete action is emitted we need to manually refresh in order to see the results