Skip to content

feat(pipelines): put the UD in product CRUD#1145

Open
CarmenPopoviciu wants to merge 2 commits intomasterfrom
feat/crud
Open

feat(pipelines): put the UD in product CRUD#1145
CarmenPopoviciu wants to merge 2 commits intomasterfrom
feat/crud

Conversation

@CarmenPopoviciu
Copy link
Contributor

No description provided.

@@ -2,44 +2,32 @@ alias: ProductEdit

parameters:
-
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to use this YAML at all if all it does is render the product form?

@teropa
Copy link
Contributor

teropa commented Apr 24, 2018

Branch doesn't run the pipelie for me, probably needs a rebase with latest fixes on master?

@CarmenPopoviciu CarmenPopoviciu force-pushed the feat/crud branch 2 times, most recently from 1ecbb11 to 5c6ba74 Compare April 25, 2018 08:07
andrei-antal and others added 2 commits April 26, 2018 15:17
feat(entity-delete): update list pipeline for actions and pass the action to the delete blocks

feat(entity-delete): Remove stand alone reference pipelines

feat(entity-delete): Refactor frontend code: pass the entity to the EntityComponent and hadle decomposition in that component

feat(entity-delete): Refactor pipe code, comment flatMap section as it blocks the create flow

feat(entity-delete): update formatting
@CarmenPopoviciu CarmenPopoviciu changed the title (WIP) feat(pipelines): put the U in product CRUD feat(pipelines): put the UD in product CRUD Apr 26, 2018
@CarmenPopoviciu
Copy link
Contributor Author

I've merged @andrei-antal 's work in this branch so we can close that PR imo. Otherwise Andrei needs to deal with all the merge hassle all over again

delete doesn't work as per your comment Tero in Andrei's PR. Not sure if it makes sense to fix that right now. WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants