Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My first Perfection Pull Request
Since this is the first feature-related code I've written on the platform, I need some perfection.
Please have a look at what I did here and provide feedback.
Idea: The ability to automatically select product templates and document layouts by just modifying a list of products: https://github.com/creativeai/platform/blob/spike/grey-structure/blocks/layout/monterrey/match/match-products.yaml
(this list could be the result of another process, like selecting products in the front-end)
Product properties are defined in content bits that are described by tags.
Product templates are selected for a given product when they contain all the tags of a given product.
When a match is made, the content of a product is injected in the receiving template at the position of the matching tags.
The same process is used to place cells thus created in a layout.
Right now, a layout is selected if it can receive the correct number of products (3 or 4 in this example).