-
Notifications
You must be signed in to change notification settings - Fork 85
Add support for Django 2.0 #85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CHANGELOG.md
Outdated
## 2.0.0 | ||
|
||
* Add support for Django 2.0 (#84) | ||
* Drop support for Django < 1.8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
CHANGELOG.md
Outdated
@@ -1,3 +1,8 @@ | |||
## 2.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if this would be 2.0. Do Django plugins track the main version of Django these days?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, just a suggestion. Was inspired by django-extensions, which I noticed went to v2.0 for Django 2.0 -- django-polymorphic is another example. I'll revert changelog changes for now, your guidance welcome.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "Drop support for Django < 1.8" is still important though. I'll make sure that gets in. I usually generate changelogs off git history.
a47a979
to
bc811d6
Compare
@@ -1,27 +1,37 @@ | |||
language: python | |||
# Workaround for Python 3.6 missing | |||
python: "3.6" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was causing all Travis builds to run on Python 3.6, which is probably not what we want... I've updated it to work as intended, its not as pretty but it works
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh yeah. I've noticed that TravisCI has real support for Python 3.6 now
539e29b
to
f370690
Compare
Adding support for Django 2.0+, and removing support for Django versions up to 1.8, the oldest supported LTS release. This allows us to replace the now deprecated django-extensions UUIDField with the Django native version, and drop a couple of other hacks. Resolves #84