Update to golang-1.23 and also update the dependencies #125
Conversation
praveenkumar
force-pushed
the
go_1.23
branch
2 times, most recently
from
88bbd77 to
8ae1887
Compare
| @@ -1,4 +1,4 @@ | |||
| FROM quay.io/almalinuxorg/8-base:8 | |||
| FROM quay.io/centos/centos:stream9 | |||
There was a problem hiding this comment.
This can be problematic as we are not going to detect when we build against a libvirt version which is too new compared to what is in rhel8.
I'll reiterate my suggestion that we stop supporting rhel8 and switch to rhel9 minimum which would avoid this issue.
There was a problem hiding this comment.
@cfergeau yes, should we wait till RHEL-10 release ?
There was a problem hiding this comment.
I'd be fine with https://libvirt.org/platforms.html
The project aims to support the most recent major version at all times. Support for the previous major version will be dropped 2 years after the new major version is released or when the vendor itself drops support, whichever comes first.
RHEL 9 was released in May 2024 almost 3 years ago, so we could follow the same policy and say we no longer support it. Especially as tools that we need (oc) have dropped support for it iirc.
But that's a team decision, not something to decide only here :)
praveenkumar
force-pushed
the
go_1.23
branch
4 times, most recently
from
6d3e092 to
a52ac8d
Compare
cfergeau
left a comment
cfergeau
left a comment
There was a problem hiding this comment.
Apart from the comments asking for the dependabot config file to be extended, ack from me.
crc is moved to use golang 1.23 and this project haven't been released/rebuilt in a long time, the latest binaries were built using go 1.21, would be good to update deps/golang version and build/release it. go-1.22 is also EOL and dep modules shifted to use go-1.23 like `sys` module. - https://endoflife.date/go
libvirt version on RHEL-8 is still libvirt-8.0.0 so we need to keep the go module accordingly.
almalinux base-8 images are based on RHEL-8 and doesn't have go-1.23.x which is required now to build the binary. Switching to centos stream9 image make sure latest version of golang available to consume. Removing curl because it is part of base image In downstream we already have go-1.23 attached to our target tag which make sure it build downstream also.
This should fix following ``` go test ./... pkg/libvirt/libvirt.go:71:13: cannot use memorySize (variable of type int) as uint value in assignment pkg/libvirt/libvirt.go:91:10: cannot use int(cpus) (value of type int) as uint value in assignment pkg/libvirt/libvirt.go:107:22: cannot use newDriver.Memory (variable of type uint) as int value in argument to d.setMemory ```
This will ensure updated version under `tools/go.mod` and also if some github action updated.
2 participants
No description provided.