-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
e2e: Add debug steps to verify the cert with CA #3782
Conversation
/hold |
0f6c225
to
2634eb1
Compare
This is just for debug purpose to understand what is actually happen when oc login require `--insecure-skip-tls-verify`.
2634eb1
to
b02c180
Compare
@praveenkumar: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/unhold @adrianriobo, let's start using that to check why the login failure happen. |
🤔 ok but not sure if we want to keep these steps on our e2e scenario, I can just create a custom version for e2e container image with these steps in and try to reproduce on downstream so may keep the hold and once I got the version we can close the PR WDYT @praveenkumar ? |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrianriobo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What is/was the login failure? What was achieved/understood thanks to this additional debug code? |
This is related to #3741 |
As part of crc-org#3782 debugging steps are added to figure out why the `oc login` require insecure sometimes but this logic fails in case the `oc` binary is not part of system path. This PR make sure that the oc command available before those debugging steps. fixes: crc-org#3792
As part of crc-org#3782 debugging steps are added to figure out why the `oc login` require insecure sometimes but this logic fails in case the `oc` binary is not part of system path. This PR make sure that the oc command available before those debugging steps. fixes: crc-org#3792
As part of crc-org#3782 debugging steps are added to figure out why the `oc login` require insecure sometimes but this logic fails in case the `oc` binary is not part of system path. This PR make sure that the oc command available before those debugging steps. fixes: crc-org#3792
This is just for debug purpose to understand what is actually happen when oc login require
--insecure-skip-tls-verify
.