Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: Add debug steps to verify the cert with CA #3782

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

praveenkumar
Copy link
Member

This is just for debug purpose to understand what is actually happen when oc login require --insecure-skip-tls-verify.

@praveenkumar
Copy link
Member Author

/hold

This is just for debug purpose to understand what is actually happen
when oc login require `--insecure-skip-tls-verify`.
@openshift-ci
Copy link

openshift-ci bot commented Aug 4, 2023

@praveenkumar: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/integration-crc b02c180 link true /test integration-crc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@praveenkumar
Copy link
Member Author

/unhold

@adrianriobo, let's start using that to check why the login failure happen.

@adrianriobo
Copy link
Contributor

adrianriobo commented Aug 7, 2023

🤔 ok but not sure if we want to keep these steps on our e2e scenario, I can just create a custom version for e2e container image with these steps in and try to reproduce on downstream so may keep the hold and once I got the version we can close the PR WDYT @praveenkumar ?

@openshift-ci
Copy link

openshift-ci bot commented Aug 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adrianriobo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Aug 7, 2023
@adrianriobo adrianriobo merged commit 9bb4cac into crc-org:main Aug 7, 2023
13 checks passed
@cfergeau
Copy link
Contributor

cfergeau commented Aug 16, 2023

What is/was the login failure? What was achieved/understood thanks to this additional debug code?

@cfergeau
Copy link
Contributor

What is/was the login failure? What was achieved/understood thanks to this additional debug code?

This is related to #3741

praveenkumar added a commit to praveenkumar/crc that referenced this pull request Aug 21, 2023
As part of crc-org#3782 debugging steps are
added to figure out why the `oc login` require insecure sometimes but
this logic fails in case the `oc` binary is not part of system path.
This PR make sure that the oc command available before those debugging
steps.

fixes: crc-org#3792
praveenkumar added a commit to praveenkumar/crc that referenced this pull request Aug 22, 2023
As part of crc-org#3782 debugging steps are
added to figure out why the `oc login` require insecure sometimes but
this logic fails in case the `oc` binary is not part of system path.
This PR make sure that the oc command available before those debugging
steps.

fixes: crc-org#3792
praveenkumar added a commit to praveenkumar/crc that referenced this pull request Aug 22, 2023
As part of crc-org#3782 debugging steps are
added to figure out why the `oc login` require insecure sometimes but
this logic fails in case the `oc` binary is not part of system path.
This PR make sure that the oc command available before those debugging
steps.

fixes: crc-org#3792
praveenkumar added a commit that referenced this pull request Aug 24, 2023
As part of #3782 debugging steps are
added to figure out why the `oc login` require insecure sometimes but
this logic fails in case the `oc` binary is not part of system path.
This PR make sure that the oc command available before those debugging
steps.

fixes: #3792
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants