Powershell Core Dectection

[stjeffrey]

This will allow Powershell Core to be detected on Windows as Powershell instead of falling back to default cmd which causes errors when running commands like crc oc-env.

[openshift-ci]

Hi @stjeffrey. Thanks for your PR.

I'm waiting for a crc-org member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[adrianriobo]

/ok-to-test

[openshift-ci]

@stjeffrey: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/integration-crc	e3b2ec9	link	true	/test integration-crc
ci/prow/e2e-crc	e3b2ec9	link	true	/test e2e-crc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[gbraad]

This addresses an old discussion we (@adrianriobo and I) had #2353

@stjeffrey does everything work as expected? That was my only concern at that time.

[stjeffrey]

This addresses an old discussion we (@adrianriobo and I) had #2353

@stjeffrey does everything work as expected? That was my only concern at that time.

Looks like the PR was already merged but I just wanted to reply to your question.
I must admint I was mostly concerned about using oc and podman commands with this patch and did not consider if it would work for things like crc setup. Given the existing codebase though with the fallback being CMD, in the context of Powershell Core I can't see how it could possibly make it any worse.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anjannath, gbraad

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [anjannath,gbraad]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment