Skip to content

Conversation

crazywhalecc
Copy link
Owner

What does this PR do?

Fix #820

Checklist before merging

If your PR involves the changes mentioned below and completed the action, please tick the corresponding option.
If a modification is not involved, please skip it directly.

  • If you modified *.php or *.json, run them locally to ensure your changes are valid:
    • PHP_CS_FIXER_IGNORE_ENV=1 composer cs-fix
    • composer analyse
    • composer test
    • bin/spc dev:sort-config
  • If it's an extension or dependency update, please ensure the following:
    • Add your test combination to src/globals/test-extensions.php.
    • If adding new or fixing bugs, add commit message containing extension test or test extensions to trigger full test suite.

@crazywhalecc crazywhalecc requested a review from henderkes July 17, 2025 04:23
@crazywhalecc crazywhalecc added the os/windows Things only for Windows label Jul 17, 2025
Copy link
Collaborator

@henderkes henderkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the corresponding settings from env.ini linux already and placed it in SPCTarget::getRuntimeLibs().

Extra libraries needed to link php are in SPC_EXTRA_LIBS that we use in various places. please update the code to use those instead.

The reasoning is that env.ini should optimally only expose relevant settings for the user to tinker with. What libraries are required to link correctly, are not relevant to the user, but to the correct working of static-php-cli itself.

@crazywhalecc crazywhalecc merged commit 3d45890 into main Jul 17, 2025
9 checks passed
@crazywhalecc crazywhalecc deleted the fix/windows-curl-sspi branch July 17, 2025 05:58
@gwleuverink
Copy link

Hey guys! I'm running into this issue on the NativePHP Windows builds. Do you have a timeline for this patch to be released?

Appreciate all your efforts on this 🙏 you rock!

@henderkes
Copy link
Collaborator

henderkes commented Jul 27, 2025

Soon. Probably not this week (as in today) but definitely next.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

os/windows Things only for Windows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build fails on Windows: linker chokes due to missing function InitSecurityInterfaceA

3 participants