force curl to respect SSL_CERT_FILE #739
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should fix problems like php/frankenphp#1610 and php/frankenphp#1627. |
dunglas
approved these changes
Jun 4, 2025
crazywhalecc
approved these changes
Jun 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
There has been a problem in recent versions where SSL_CERT_FILE, SSL_CERT_DIR and CURL_CA_BUNDLE are not respected.
Even though it's not documented, it seems like it's no longer possible to let openssl handle the location unless the paths are disabled in the curl build.
For what it's worth, it still finds the ca bundle even if the environment variables are not set, I believe due to openssl's logic around it.