Skip to content

rename SPC_RETRY_TIME to SPC_DOWNLOAD_RETRIES to clear up what it's doing sleep 5 seconds between retries #707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 22, 2025
Merged

rename SPC_RETRY_TIME to SPC_DOWNLOAD_RETRIES to clear up what it's doing sleep 5 seconds between retries #707

merged 4 commits into from
Apr 22, 2025

Conversation

henderkes
Copy link
Collaborator

@henderkes henderkes commented Apr 22, 2025 •
edited
Loading

What does this PR do?

use curls built in retry functionality instead of immediately going for retries ourselves, which are almost bound to fail without a sleep in between

Checklist before merging

If your PR involves the changes mentioned below and completed the action, please tick the corresponding option.
If a modification is not involved, please skip it directly.

  • If you modified *.php, run composer cs-fix at local machine.

@henderkes henderkes requested a review from crazywhalecc April 22, 2025 07:54
@crazywhalecc crazywhalecc added the kind/framework Issues related to CLI app framework label Apr 22, 2025
@henderkes henderkes merged commit 637ae89 into main Apr 22, 2025
6 checks passed
@crazywhalecc crazywhalecc deleted the retries branch April 22, 2025 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@crazywhalecc crazywhalecc crazywhalecc approved these changes

Assignees

No one assigned

Labels

kind/framework Issues related to CLI app framework

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@henderkes @crazywhalecc