expression: maintain DeferredExpr in aggressive constant folding. (p…

…ingcap#7926)
crazycs520 · Oct 18, 2018 · 3e3b905 · 3e3b905
1 parent 0f587c3
commit 3e3b905
Show file tree

Hide file tree

Showing 2 changed files with 34 additions and 0 deletions.
diff --git a/expression/constant_fold.go b/expression/constant_fold.go
@@ -118,9 +118,15 @@ func foldConstant(expr Expression) (Expression, bool) {
 				return expr, isDeferredConst
 			}
 			if value.IsNull() {
+				if isDeferredConst {
+					return &Constant{Value: value, RetType: x.RetType, DeferredExpr: x}, true
+				}
 				return &Constant{Value: value, RetType: x.RetType}, false
 			}
 			if isTrue, err := value.ToBool(sc); err == nil && isTrue == 0 {
+				if isDeferredConst {
+					return &Constant{Value: value, RetType: x.RetType, DeferredExpr: x}, true
+				}
 				return &Constant{Value: value, RetType: x.RetType}, false
 			}
 			return expr, isDeferredConst

diff --git a/expression/constant_test.go b/expression/constant_test.go
@@ -202,3 +202,31 @@ func (*testExpressionSuite) TestConstantFolding(c *C) {
 		c.Assert(newConds.String(), Equals, tt.result, Commentf("different for expr %s", tt.condition))
 	}
 }
+
+func (*testExpressionSuite) TestDeferredExprNullConstantFold(c *C) {
+	defer testleak.AfterTest(c)()
+	nullConst := &Constant{
+		Value:        types.NewDatum(nil),
+		RetType:      types.NewFieldType(mysql.TypeTiny),
+		DeferredExpr: Null,
+	}
+	tests := []struct {
+		condition Expression
+		deferred  string
+	}{
+		{
+			condition: newFunction(ast.LT, newColumn(0), nullConst),
+			deferred:  "lt(test.t.0, <nil>)",
+		},
+	}
+	for _, tt := range tests {
+		comment := Commentf("different for expr %s", tt.condition)
+		sf, ok := tt.condition.(*ScalarFunction)
+		c.Assert(ok, IsTrue, comment)
+		sf.GetCtx().GetSessionVars().StmtCtx.InNullRejectCheck = true
+		newConds := FoldConstant(tt.condition)
+		newConst, ok := newConds.(*Constant)
+		c.Assert(ok, IsTrue, comment)
+		c.Assert(newConst.DeferredExpr.String(), Equals, tt.deferred, comment)
+	}
+}