[LangChain] Add example programs and notebooks #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amotl
commented
Oct 16, 2023
ckurze
reviewed
Oct 16, 2023
| "from pprint import pprint\n", | ||
| "\n", | ||
| "CONNECTION_STRING = \"crate://crate@localhost/?schema=notebook\"\n", | ||
| "\n", |
There was a problem hiding this comment.
Do we need the schema in the connection string? For me, it causes a failure on the SELECT statement below, because mlb_teams_2012? is apparently created in the doc` schema.
There was a problem hiding this comment.
6779392 should fix that flaw. I would like to use it, in order to educate people about it.
ckurze
reviewed
Oct 16, 2023
ckurze
reviewed
Oct 17, 2023
framework/langchain/readme.md
Outdated
|
|
||
| ### CrateDB Cloud | ||
|
|
||
| Todo. |
There was a problem hiding this comment.
Suggested change
| Todo. | |
| Sign up or log in to [CrateDB Cloud](https://console.cratedb.cloud) and create a free tier cluster. Within just a few minutes, you will have a cloud-based development environment. As soon as your project scales, you can easily move to a different cluster tier or scale horizontally. |
ckurze
force-pushed
the
amo/framework-langchain
branch
2 times, most recently
from
cc2943c to
1965489
Compare
amotl
commented
Oct 23, 2023
amotl
force-pushed
the
amo/framework-langchain
branch
7 times, most recently
from
8fd2d10 to
dbf3dab
Compare
|
Within the README, there are now badges to open the Jupyter Notebooks on GitHub, on Binder, and on Google Colab. See LangChain and CrateDB » What's inside. |
amotl
commented
Oct 29, 2023
Comment on lines
+395
to
+437
| { | ||
| "cell_type": "markdown", | ||
| "metadata": {}, | ||
| "source": [ | ||
| "### Overwriting a vector store\n", | ||
| "\n", | ||
| "If you have an existing collection, you can overwrite it by using `from_documents`,\n", | ||
| "aad setting `pre_delete_collection = True`." | ||
| ] | ||
| }, | ||
| { | ||
| "cell_type": "code", | ||
| "execution_count": null, | ||
| "metadata": {}, | ||
| "outputs": [], | ||
| "source": [ | ||
| "db = CrateDBVectorSearch.from_documents(\n", | ||
| " documents=docs,\n", | ||
| " embedding=embeddings,\n", | ||
| " collection_name=COLLECTION_NAME,\n", | ||
| " connection_string=CONNECTION_STRING,\n", | ||
| " pre_delete_collection=True,\n", | ||
| ")" | ||
| ] | ||
| }, | ||
| { | ||
| "cell_type": "code", | ||
| "execution_count": null, | ||
| "metadata": {}, | ||
| "outputs": [], | ||
| "source": [ | ||
| "docs_with_score = db.similarity_search_with_score(\"foo\")" | ||
| ] | ||
| }, | ||
| { | ||
| "cell_type": "code", | ||
| "execution_count": null, | ||
| "metadata": {}, | ||
| "outputs": [], | ||
| "source": [ | ||
| "docs_with_score[0]" | ||
| ] | ||
| }, |
There was a problem hiding this comment.
I am observing problems here. It is probably related to the other report by @ckurze.
There was a problem hiding this comment.
Adding software tests will help to keep our sanity.
amotl
force-pushed
the
amo/framework-langchain
branch
from
7cf13da to
cd92557
Compare
1 task
amotl
changed the base branch from
amo/python-sqlalchemy
to
amo/ngr-everywhere
amotl
changed the title
amotl
force-pushed
the
amo/ngr-everywhere
branch
from
f43c9f5 to
f5546bf
Compare
amotl
force-pushed
the
amo/framework-langchain
branch
from
cd92557 to
cd9b202
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
We have been looking into making LangChain work together with CrateDB. This patch adds corresponding example programs and Jupyter Notebooks.
Preview
Readme, rendered by GitHub: LangChain and CrateDB
Backlog
both the basic example programs, and the Jupyter Notebooks.
/cc @marijaselakovic, @hammerhead, @seut, @ckurze