Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debug #330

Closed
wants to merge 12 commits into from
Closed

debug #330

wants to merge 12 commits into from

Conversation

BaurzhanSakhariev
Copy link
Contributor

Reproduction for crate/crate#17150

@BaurzhanSakhariev BaurzhanSakhariev force-pushed the b/removed-setting branch 4 times, most recently from 1be778e to aa8ca25 Compare December 20, 2024 13:42
@BaurzhanSakhariev BaurzhanSakhariev marked this pull request as draft December 20, 2024 13:42
@BaurzhanSakhariev BaurzhanSakhariev force-pushed the b/removed-setting branch 2 times, most recently from 4a7e0e9 to 0d841bb Compare December 20, 2024 14:05
@BaurzhanSakhariev BaurzhanSakhariev force-pushed the b/removed-setting branch 3 times, most recently from 8f0e152 to 6b11582 Compare December 20, 2024 14:43
@BaurzhanSakhariev BaurzhanSakhariev force-pushed the b/removed-setting branch 2 times, most recently from f37f9c2 to 133b62a Compare December 20, 2024 15:00
@BaurzhanSakhariev BaurzhanSakhariev force-pushed the b/removed-setting branch 2 times, most recently from 40c7d73 to 4ca4175 Compare December 23, 2024 16:39
@BaurzhanSakhariev
Copy link
Contributor Author

BaurzhanSakhariev commented Dec 27, 2024

retest this please

unrelated

 self.assertEqual(res[0][1], 'hello')

AssertionError: None != 'hello'

UPD: I created #331 to show that failure of dynamic sub-column of the ignored column is unrelated (and can't be as it's on a non-partitioned table).

Removed unrelated and not supported 5.7-> nightly test in 84c5a93 to not pollute this PR with unrelated failures.

@BaurzhanSakhariev
Copy link
Contributor Author

BaurzhanSakhariev commented Dec 27, 2024

CI failure on 5.7 -> 5.8

Caused by: java.lang.IllegalArgumentException: unknown setting [index.warmer.enabled] please check that any required plugins are installed, or check the breaking changes documentation for removed settings

	at org.elasticsearch.common.settings.AbstractScopedSettings.validate(AbstractScopedSettings.java:421)

	at org.elasticsearch.common.settings.AbstractScopedSettings.validate(AbstractScopedSettings.java:362)

	at org.elasticsearch.common.settings.AbstractScopedSettings.validate(AbstractScopedSettings.java:333)

	at org.elasticsearch.indices.IndicesService.createIndexService(IndicesService.java:437)

	at org.elasticsearch.indices.IndicesService.createIndex(IndicesService.java:364)

	at org.elasticsearch.action.admin.indices.create.TransportCreatePartitionsAction.executeCreateIndices(TransportCreatePartitionsAction.java:237)

	at org.elasticsearch.action.admin.indices.create.TransportCreatePartitionsAction.lambda$new$0(TransportCreatePartitionsAction.java:102)

	at org.elasticsearch.cluster.service.MasterService.executeTasks(MasterService.java:665)

bwc_rolling_upgrade test passes with UpgradePath('5.7.5', 'branch:b/create-partition-fix'),

@BaurzhanSakhariev
Copy link
Contributor Author

this PR won't be merged - doesn't make sense to create a table with a setting that was removed in 5.7 because we can't apply this statement on next 5.8+ UpgradePath combinations

@BaurzhanSakhariev BaurzhanSakhariev deleted the b/removed-setting branch January 13, 2025 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant