SQLAlchemy deprecation in SqlAlchemyDictTypeTest

src/crate/client/sqlalchemy/tests/dict_test.py

@@ -37,12 +37,11 @@
 
 
 class SqlAlchemyDictTypeTest(TestCase):
-
     def setUp(self):
         self.engine = sa.create_engine('crate://')
-        # FIXME: Deprecated with SA20.
-        metadata = sa.MetaData(bind=self.engine)
-        self.mytable = sa.Table('mytable', metadata,
+        metadata = sa.MetaData()
+        self.mytable = sa.Table('mytable',
+                                metadata,
                                 sa.Column('name', sa.String),
                                 sa.Column('data', Craty))
 
@@ -52,7 +51,7 @@ def assertSQL(self, expected_str, actual_expr):
     def test_select_with_dict_column(self):
         mytable = self.mytable
         self.assertSQL(
-            "SELECT mytable.data['x'] AS anon_1 FROM mytable",
+            "SELECT mytable.data[:data_1] AS anon_1 FROM mytable",
             select(mytable.c.data['x'])
         )
 
@@ -61,7 +60,7 @@ def test_select_with_dict_column_where_clause(self):
         s = select(mytable.c.data).\
             where(mytable.c.data['x'] == 1)
         self.assertSQL(
-            "SELECT mytable.data FROM mytable WHERE mytable.data['x'] = ?",
+            "SELECT mytable.data FROM mytable WHERE mytable.data[:data_1] = :param_1",
             s
         )
 
@@ -71,7 +70,7 @@ def test_select_with_dict_column_nested_where(self):
         s = s.where(mytable.c.data['x']['y'] == 1)
         self.assertSQL(
             "SELECT mytable.name FROM mytable " +
-            "WHERE mytable.data['x']['y'] = ?",
+            "WHERE mytable.data[:data_1][:param_1] = :param_2",
             s
         )
 
@@ -80,7 +79,7 @@ def test_select_with_dict_column_where_clause_gt(self):
         s = select(mytable.c.data).\
             where(mytable.c.data['x'] > 1)
         self.assertSQL(
-            "SELECT mytable.data FROM mytable WHERE mytable.data['x'] > ?",
+            "SELECT mytable.data FROM mytable WHERE mytable.data[:data_1] > :param_1",
             s
         )
 
@@ -90,19 +89,18 @@ def test_select_with_dict_column_where_clause_other_col(self):
         s = s.where(mytable.c.data['x'] == mytable.c.name)
         self.assertSQL(
             "SELECT mytable.name FROM mytable " +
-            "WHERE mytable.data['x'] = mytable.name",
+            "WHERE mytable.data[:data_1] = mytable.name",
             s
         )
 
     def test_update_with_dict_column(self):
         mytable = self.mytable
         stmt = mytable.update().\
             where(mytable.c.name == 'Arthur Dent').\
-            values({
-                "data['x']": "Trillian"
-            })
+            values({mytable.c.data['x']: "Trillian"})
+
         self.assertSQL(
-            "UPDATE mytable SET data['x'] = ? WHERE mytable.name = ?",
+            "UPDATE mytable SET data[:data_1]=:param_1 WHERE mytable.name = :name_1",
             stmt
         )