Skip to content

Conversation

@amotl
Copy link
Member

@amotl amotl commented May 9, 2023

As a followup to GH-145, this patch concludes the renaming. In order to not break existing code, a compatibility shim has been added at Crate\PDO\PDO, which will be removed on a later release.

@amotl amotl requested review from matriv and seut May 9, 2023 13:58
@amotl amotl marked this pull request as ready for review May 9, 2023 13:58
@amotl
Copy link
Member Author

amotl commented May 9, 2023

CI observations

I don't know why Codecov complains here.

[codecov/patch] Failing after 1s — 84.87% of diff hit (target 89.37%)

From my perspective, it does not look too bad?

-- https://github.com/crate/crate-pdo/pull/148/checks?check_run_id=13344646751
-- https://app.codecov.io/gh/crate/crate-pdo/pull/148


But indeed, Scrutinizer also reports about it:

Test Coverage has decreased to 88% (-2%).

-- https://scrutinizer-ci.com/g/crate/crate-pdo/inspections/92013af8-5ae5-4551-917c-bb6dc140f542

Question

Do you think we can tolerate it?

Copy link
Member

@seut seut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! But we should mention this at the CHANGES or?

In order to not break existing code, a compatibility shim has been added
at `Crate\PDO\PDO`, which will be removed on a later release.
@amotl amotl force-pushed the amo/rename-pdo-class branch from 0dee173 to 74a1599 Compare May 9, 2023 14:18
@amotl amotl merged commit 7a3b516 into main May 9, 2023
@amotl amotl deleted the amo/rename-pdo-class branch May 9, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants