Skip to content

Add Exposure enum for spec.cluster.exposure - #921

Open
WalBeh wants to merge 2 commits into
wb/clusterip-exposurefrom
wb/exposure-enum
Open

WalBeh wants to merge 2 commits into
wb/clusterip-exposurefrom
wb/exposure-enum

Conversation

@WalBeh

@WalBeh WalBeh commented Oct 20, 2026

Copy link
Copy Markdown
Contributor

Summary of changes

The exposure mode was read with its own default in ten places and checked with string compares, so adding clusterip in #920 meant a search for every == "traefik" check. An Exposure enum keeps the default and the checks in one place. Grand-central now maps the cluster exposure to nginx or traefik explicitly instead of returning the cluster value. No behaviour change. Based on #920.

Checklist

The mode was read with its own default in ten places and checked with
string compares, so adding clusterip meant a search for every
`== "traefik"` check. Grand-central now maps the cluster exposure to
nginx or traefik instead of returning the cluster value. No behaviour
change.

Assisted-by: Claude Code (LLM-assisted)
Python 3.12 formats a str mixin enum as "Exposure.CLUSTERIP", which
changed the exposure log lines.

Assisted-by: Claude Code (LLM-assisted)
@WalBeh
WalBeh requested a review from tomach October 21, 2026 10:32

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant