Chore: Switch linter/formatter to PHP Coding Standards Fixer

It also has a ruleset to order `use` statements.

- https://github.com/PHP-CS-Fixer/PHP-CS-Fixer
- https://cs.symfony.com/doc/rules/import/ordered_imports.html

Before: PHP_CodeSniffer
- https://github.com/PHPCSStandards/PHP_CodeSniffer

Author: amotl

.gitignore

@@ -3,6 +3,7 @@
 .project
 .vagrant
 .phpunit.result.cache
+*.cache
 *-console.log
 .crate-docs
 /composer.lock

.php-cs-fixer.php

@@ -0,0 +1,26 @@
+<?php
+// PHP Coding Standards Fixer
+// https://cs.symfony.com/
+// https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/blob/master/doc/config.rst
+
+$finder = (new PhpCsFixer\Finder())
+    ->in(__DIR__)
+;
+
+return (new PhpCsFixer\Config())
+    ->setUnsupportedPhpVersionAllowed(true)
+    ->setRules([
+        // '@auto' => true,
+        // '@PHP7x3Migration' => true,
+        // '@PSR1' => true,
+        // '@PSR2' => true,
+        // '@PSR12' => true,
+        // '@Symfony' => true,
+        // 'array_syntax' => ['syntax' => 'short'],
+        'ordered_imports' => true,
+        // 'strict_param' => true,
+    ])
+    ->setFinder($finder)
+    ;
+
+?>

composer.json

@@ -27,7 +27,7 @@
     },
     "require-dev": {
         "phpunit/phpunit": "^9.0",
-        "squizlabs/php_codesniffer": "^3.5"
+        "friendsofphp/php-cs-fixer": "^3.89"
     },
     "autoload-dev": {
         "psr-0": {
@@ -44,7 +44,7 @@
     },
     "scripts": {
         "test": "XDEBUG_MODE=coverage phpunit --coverage-clover build/logs/clover.xml",
-        "check-style": "phpcs -s",
-        "fix-style": "phpcbf"
+        "check-style": "php-cs-fixer check",
+        "fix-style": "php-cs-fixer fix"
     }
 }

examples/objects.php

@@ -6,15 +6,15 @@
  */
 require __DIR__ . '/../vendor/autoload.php';
 
+use Crate\DBAL\Platforms\CratePlatform4;
+use Crate\DBAL\Types\MapType;
+use Doctrine\DBAL\DriverManager;
 use Doctrine\DBAL\Exception\TableNotFoundException;
 use Doctrine\DBAL\Schema\Column;
 use Doctrine\DBAL\Schema\Table;
+
 use Doctrine\DBAL\Tools\DsnParser;
 use Doctrine\DBAL\Types\Type;
-use Doctrine\DBAL\DriverManager;
-
-use Crate\DBAL\Platforms\CratePlatform4;
-use Crate\DBAL\Types\MapType;
 
 // Initialize machinery.
 // This ensures that the 'map' type is registered in the type system from the beginning.

src/Crate/DBAL/Driver/PDOCrate/CrateStatement.php

@@ -1,4 +1,5 @@
 <?php
+
 /**
  * Licensed to CRATE Technology GmbH("Crate") under one or more contributor
  * license agreements.  See the NOTICE file distributed with this work for
@@ -22,12 +23,12 @@
 
 namespace Crate\DBAL\Driver\PDOCrate;
 
-use Crate\PDO\PDOStatement;
 use Crate\PDO\PDOInterface;
+use Crate\PDO\PDOStatement;
 use Doctrine\DBAL\Driver\PDO\Exception;
 use Doctrine\DBAL\Driver\PDOStatementImplementations;
-use Doctrine\DBAL\Driver\Statement as StatementInterface;
 use Doctrine\DBAL\Driver\Result as ResultInterface;
+use Doctrine\DBAL\Driver\Statement as StatementInterface;
 use Doctrine\DBAL\ParameterType;
 use Doctrine\Deprecations\Deprecation;
 use PDO;

src/Crate/DBAL/Driver/PDOCrate/Driver.php

@@ -1,4 +1,5 @@
 <?php
+
 /**
  * Licensed to CRATE Technology GmbH("Crate") under one or more contributor
  * license agreements.  See the NOTICE file distributed with this work for
@@ -19,10 +20,11 @@
  * with Crate these terms will supersede the license and you may use the
  * software solely pursuant to the terms of the relevant commercial agreement.
  */
+
 namespace Crate\DBAL\Driver\PDOCrate;
 
-use Crate\DBAL\Platforms\CratePlatform1;
 use Crate\DBAL\Platforms\CratePlatform;
+use Crate\DBAL\Platforms\CratePlatform1;
 use Crate\DBAL\Platforms\CratePlatform4;
 use Crate\DBAL\Schema\CrateSchemaManager;
 use Doctrine\DBAL\Connection;
@@ -32,8 +34,8 @@
 
 class Driver implements \Doctrine\DBAL\Driver
 {
-    const VERSION = '4.0.3';
-    const NAME = 'crate';
+    public const VERSION = '4.0.3';
+    public const NAME = 'crate';
 
     private const VERSION_057 = '0.57.0';
     private const VERSION_4 = '4.0.0';

src/Crate/DBAL/Driver/PDOCrate/ExceptionConverter.php

@@ -15,8 +15,8 @@
 use Doctrine\DBAL\Exception\TableNotFoundException;
 use Doctrine\DBAL\Exception\UniqueConstraintViolationException;
 use Doctrine\DBAL\Query;
-
 use Doctrine\DBAL\Schema\Exception\ColumnDoesNotExist;
+
 use function strpos;
 
 /** @internal */

src/Crate/DBAL/Driver/PDOCrate/PDOConnection.php

@@ -1,4 +1,5 @@
 <?php
+
 /**
  * Licensed to CRATE Technology GmbH("Crate") under one or more contributor
  * license agreements.  See the NOTICE file distributed with this work for
@@ -24,16 +25,15 @@
 
 use Crate\PDO\PDOCrateDB;
 use Crate\PDO\PDOStatement;
+use Doctrine\DBAL\Driver\Connection as ConnectionInterface;
 use Doctrine\DBAL\Driver\PDO\Exception;
 use Doctrine\DBAL\Driver\Result as ResultInterface;
-use Doctrine\DBAL\Driver\Connection as ConnectionInterface;
 use Doctrine\DBAL\ParameterType;
 use PDO;
 use PDOException;
 
 class PDOConnection implements ConnectionInterface
 {
-
     private PDOCrateDB $connection;
 
     /**

src/Crate/DBAL/Platforms/CratePlatform.php

@@ -1,4 +1,5 @@
 <?php
+
 /**
  * Licensed to CRATE Technology GmbH("Crate") under one or more contributor
  * license agreements.  See the NOTICE file distributed with this work for
@@ -19,6 +20,7 @@
  * with Crate these terms will supersede the license and you may use the
  * software solely pursuant to the terms of the relevant commercial agreement.
  */
+
 namespace Crate\DBAL\Platforms;
 
 use Crate\DBAL\Types\MapType;
@@ -28,20 +30,19 @@
 use Doctrine\DBAL\Events;
 use Doctrine\DBAL\Exception as DBALException;
 use Doctrine\DBAL\Platforms\AbstractPlatform;
+use Doctrine\DBAL\Schema\ForeignKeyConstraint;
 use Doctrine\DBAL\Schema\Identifier;
 use Doctrine\DBAL\Schema\Index;
 use Doctrine\DBAL\Schema\Table;
 use Doctrine\DBAL\Schema\TableDiff;
 use Doctrine\DBAL\Types\Type;
-use Doctrine\DBAL\Schema\ForeignKeyConstraint;
 use InvalidArgumentException;
 
 class CratePlatform extends AbstractPlatform
 {
-
-    const TIMESTAMP_FORMAT =  'Y-m-d\TH:i:s';
-    const TIMESTAMP_FORMAT_TZ =  'Y-m-d\TH:i:sO';
-    const TABLE_WHERE_CLAUSE_FORMAT = '%s.table_name = %s AND %s.schema_name = %s';
+    public const TIMESTAMP_FORMAT =  'Y-m-d\TH:i:s';
+    public const TIMESTAMP_FORMAT_TZ =  'Y-m-d\TH:i:sO';
+    public const TABLE_WHERE_CLAUSE_FORMAT = '%s.table_name = %s AND %s.schema_name = %s';
 
     /**
      * {@inheritDoc}
@@ -605,7 +606,7 @@ public function getCreateTableSQL(Table $table, $createFlags = self::CREATE_INDE
         $options['indexes'] = array();
         $options['primary'] = array();
 
-        if (($createFlags&self::CREATE_INDEXES) > 0) {
+        if (($createFlags & self::CREATE_INDEXES) > 0) {
             foreach ($table->getIndexes() as $index) {
                 /* @var $index Index */
                 if ($index->isPrimary()) {
@@ -686,7 +687,7 @@ protected function _getCreateTableSQL($name, array $columns, array $options = ar
                 $columnListSql .= ', ' . $this->getIndexDeclarationSQL($index, $definition);
             }
         }
- 
+
         if (isset($options['foreignKeys'])) {
             throw DBALException::notSupported("Create Table: foreign keys");
         }
@@ -831,15 +832,15 @@ public function getDropDatabaseSQL($database)
     {
         throw DBALException::notSupported(__METHOD__);
     }
-    
+
     /**
      * {@inheritDoc}
      */
     public function getCreateForeignKeySQL(ForeignKeyConstraint $foreignKey, $table)
     {
         throw DBALException::notSupported(__METHOD__);
     }
-    
+
     /**
      * {@inheritDoc}
      */
@@ -854,7 +855,7 @@ public function getGuidTypeDeclarationSQL(array $field)
      *
      * @return string
      */
-    public function getTableOptionsSQL(string $table) : string
+    public function getTableOptionsSQL(string $table): string
     {
         return "SELECT clustered_by, number_of_shards, partitioned_by, number_of_replicas, column_policy, settings " .
                "FROM information_schema.tables c " .

src/Crate/DBAL/Platforms/CratePlatform1.php

@@ -1,4 +1,5 @@
 <?php
+
 /**
  * Licensed to CRATE Technology GmbH("Crate") under one or more contributor
  * license agreements.  See the NOTICE file distributed with this work for
@@ -24,7 +25,7 @@
 
 class CratePlatform1 extends CratePlatform
 {
-    const TABLE_WHERE_CLAUSE_FORMAT_1 = '%s.table_name = %s AND %s.table_schema = %s';
+    public const TABLE_WHERE_CLAUSE_FORMAT_1 = '%s.table_name = %s AND %s.table_schema = %s';
 
     /**
      * {@inheritDoc}