DBAL3: More copy editing with CodeRabbit

Author: amotl

docs/connect.rst

@@ -29,13 +29,15 @@ If you plan to query CrateDB via DBAL, you can get a connection from the
 
 .. code-block:: php
 
+    use Doctrine\DBAL\DriverManager;
+
     $params = array(
         'driverClass' => 'Crate\DBAL\Driver\PDOCrate\Driver',
         'user' => 'crate',
         'host' => 'localhost',
         'port' => 4200
     );
-    $connection = \Doctrine\DBAL\DriverManager::getConnection($params);
+    $connection = DriverManager::getConnection($params);
     $schemaManager = $connection->createSchemaManager();
 
 With these connection parameters, the ``DriverManager`` will attempt to

examples/objects.php

@@ -17,6 +17,7 @@
 use Crate\DBAL\Types\MapType;
 
 // Initialize machinery.
+// This ensures that the 'map' type is registered in the type system from the beginning.
 $platform = new CratePlatform4();
 
 // Define table schema.
@@ -44,7 +45,7 @@
 
 // Provision database table.
 try {
-    $schemaManager->dropTable($table);
+    $schemaManager->dropTable($table->getName());
 } catch (TableNotFoundException) {
 }
 $schemaManager->createTable($table);

src/Crate/DBAL/Driver/PDOCrate/Driver.php

@@ -28,6 +28,7 @@
 use Doctrine\DBAL\Connection;
 use Doctrine\DBAL\Platforms\AbstractPlatform;
 use Doctrine\DBAL\Schema\AbstractSchemaManager;
+use SensitiveParameter;
 
 class Driver implements \Doctrine\DBAL\Driver
 {
@@ -42,11 +43,12 @@ class Driver implements \Doctrine\DBAL\Driver
      * @return PDOConnection The database connection.
      */
     public function connect(
-        array $params,
-        $username = null,
-        $password = null,
-        array $driverOptions = array(),
+        #[SensitiveParameter]
+        array $params
     ): PDOConnection {
+        $username = $params['user'] ?? null;
+        $password = $params['password'] ?? null;
+        $driverOptions = $params['driver_options'] ?? [];
         return new PDOConnection($this->constructPdoDsn($params), $username, $password, $driverOptions);
     }
 

src/Crate/DBAL/Platforms/CratePlatform.php

@@ -795,7 +795,8 @@ public static function prepareColumnData(AbstractPlatform $platform, $column, $p
         $columnData['unique'] = false;
         $columnData['version'] = $column->hasPlatformOption("version") ? $column->getPlatformOption("version") : false;
 
-        if (strtolower($columnData['type']->getName()) == $platform->getVarcharTypeDeclarationSQLSnippet(0, false)
+        if (strtolower($columnData['type']->getName()) ==
+            strtolower($platform->getVarcharTypeDeclarationSQLSnippet(0, false))
                 && $columnData['length'] === null) {
             $columnData['length'] = 255;
         }

test/Crate/Test/DBAL/Functional/ConnectionTest.php

@@ -23,6 +23,7 @@
 
 use Crate\Test\DBAL\DBALFunctionalTestCase;
 use Crate\PDO\PDOCrateDB;
+use Doctrine\DBAL\DriverManager;
 
 class ConnectionTestCase extends DBALFunctionalTestCase
 {
@@ -50,12 +51,11 @@ public function testBasicAuthConnection()
             'user' => $auth[0],
             'password' => $auth[1],
         );
-        $conn = \Doctrine\DBAL\DriverManager::getConnection($params);
+        $conn = DriverManager::getConnection($params);
         $conn->connect();
         $credentials = $conn->getNativeConnection()->getAttribute(PDOCrateDB::CRATE_ATTR_HTTP_BASIC_AUTH);
 
-        // No credential leaks any longer: Any empty array is all we got.
-        $this->assertEquals(array(), $credentials);
+        $this->assertEquals(array("crate", "secret"), $credentials);
     }
 
     public function testGetConnection()