DynamoDB: Change CrateDB data model to use (pk, data, aux) columns
#64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amotl
force-pushed
the
dynamodb-fix-cdc
branch
from
e31666b to
155377d
Compare
amotl
force-pushed
the
dynamodb-fix-cdc
branch
from
155377d to
b73ef4d
Compare
hammerhead
reviewed
Sep 30, 2024
| f"CREATE TABLE IF NOT EXISTS {self.table_name} " | ||
| f"({self.TYPED_COLUMN} OBJECT(DYNAMIC), {self.UNTYPED_COLUMN} OBJECT(IGNORED));" | ||
| f"CREATE TABLE IF NOT EXISTS {self.table_name} (" | ||
| f"{self.PK_COLUMN} OBJECT(DYNAMIC) AS ({', '.join(self.primary_key_schema.to_sql_ddl_clauses())}), " |
There was a problem hiding this comment.
Should we rather make the pk_column an OBJECT(STRICT)? The primary key cannot be changed on an existing table. Although it doesn't make a difference in practice, since the object isn't the primary key, but the elements inside. And an OBJECT(STRICT) also still can be changed through an ALTER TABLE ADD COLUMN. It just looks a bit untypical to have a dynamic PK. Are there scenarios where new attributes would be added to the PK object during runtime?
There was a problem hiding this comment.
I am absolutely fine using OBJECT(STRICT), as you are suggesting. Thanks!
By breaking the primary key information out of the main record's data bucket, the main record can be updated as-is on CDC MODIFY operations.
amotl
force-pushed
the
dynamodb-fix-cdc
branch
from
b73ef4d to
66bf65d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
By breaking the primary key information out of the main record's data bucket, the main record can be updated as-is on CDC MODIFY operations.
References
pk,data,aux) columns cratedb-toolkit#281