-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DynamoDB: Fix String Set
and Number Set
representation to CrateDB.
#27
Conversation
BinarySet pending |
f77bc24
to
1d1ba00
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent, thank you so much. I just added one comment where I am not sure whether it needs improvements before merging.
ea8796b
to
58404f7
Compare
58404f7
to
9997130
Compare
I pulled out |
Hi. In order to keep vendorized code unmodified, and code coverage at 100%, I've submitted an alternative implementation. |
Closing this, because reasons.. |
Thanks a stack @surister. Just code shuffling. Credit is yours! 💯 |
Hi again. Because there might have been misunderstandings about the genesis of GH-29: It is 100% originating from this patch. I just had to hand it in separately, because I did not have access to your fork, and thus wasn't able to stack another amendment patch on top of yours. Thanks again for submitting this improvement. It is included in relevant releases, and makes a huge difference now able to converge corresponding DynamoDB data types well. |
Summary of the changes / Why this is an improvement
Fixes #26
Checklist