Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DynamoDB: Fix String Set and Number Set representation to CrateDB. #27

Closed
wants to merge 1 commit into from

Conversation

surister
Copy link
Contributor

Summary of the changes / Why this is an improvement

Fixes #26

Checklist

  • Link to issue this PR refers to (if applicable):
  • CLA is signed

@surister
Copy link
Contributor Author

BinarySet pending

@surister surister force-pushed the dynamo-types-extra branch 2 times, most recently from f77bc24 to 1d1ba00 Compare August 20, 2024 18:58
Copy link
Member

@amotl amotl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thank you so much. I just added one comment where I am not sure whether it needs improvements before merging.

tests/transform/test_dynamodb.py Outdated Show resolved Hide resolved
tests/transform/test_dynamodb_types.py Show resolved Hide resolved
@surister surister force-pushed the dynamo-types-extra branch 2 times, most recently from ea8796b to 58404f7 Compare August 21, 2024 21:12
@surister
Copy link
Contributor Author

I pulled out Binary and Decimal classes and just used the values from the source, we can rethink this in the future but at least now the generated SQL seems correct, please check that tests/transform/test_dynamodb.py produce correct CrateDB SQL, I think so but something could have slipped

@amotl
Copy link
Member

amotl commented Aug 22, 2024

Hi. In order to keep vendorized code unmodified, and code coverage at 100%, I've submitted an alternative implementation.

@surister
Copy link
Contributor Author

Closing this, because reasons..

@surister surister closed this Aug 22, 2024
@amotl
Copy link
Member

amotl commented Aug 22, 2024

Thanks a stack @surister. Just code shuffling. Credit is yours! 💯

@amotl
Copy link
Member

amotl commented Aug 27, 2024

Hi again. Because there might have been misunderstandings about the genesis of GH-29: It is 100% originating from this patch. I just had to hand it in separately, because I did not have access to your fork, and thus wasn't able to stack another amendment patch on top of yours.

Thanks again for submitting this improvement. It is included in relevant releases, and makes a huge difference now able to converge corresponding DynamoDB data types well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DynamoDB: StringSet, NumberSet, BinarySet cannot be sent to CrateDB
2 participants