Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: convert benchmark for single cell verification to batch verification #80

Merged

Conversation

jtraglia
Copy link
Contributor

Noticed this wasn't being benchmarked & we're about to remove single cell verification.

Here are the results from my system. I was a little surprised that num_threads didn't make a difference. Is that normal?

verify_cell_kzg_proof_batch - NUM_THREADS: 1
                        time:   [11.931 ms 11.954 ms 11.977 ms]
verify_cell_kzg_proof_batch - NUM_THREADS: 4
                        time:   [11.915 ms 11.951 ms 11.999 ms]
verify_cell_kzg_proof_batch - NUM_THREADS: 8
                        time:   [11.940 ms 11.965 ms 11.992 ms]
verify_cell_kzg_proof_batch - NUM_THREADS: 16
                        time:   [11.931 ms 11.958 ms 11.987 ms]
verify_cell_kzg_proof_batch - NUM_THREADS: 32
                        time:   [11.897 ms 11.920 ms 11.944 ms]

@jtraglia jtraglia changed the title Convert benchmark for single cell verification to batch verification chore: convert benchmark for single cell verification to batch verification Jul 16, 2024
@kevaundray
Copy link
Contributor

I was a little surprised that num_threads didn't make a difference.

The benchmarks seem to only be using a single commitment, which saves quite a bit of MSMs -- currently the FFT algorithm is not parallelized, so I think this is expected, I would expect more of a discrepancy if we were to use different commitments

@kevaundray
Copy link
Contributor

The choosenim github action has been flaky over the last couple of months -- going to merge since it passes for nim on ubuntu and windows, and its only modifying benchmark code

@kevaundray kevaundray merged commit 382a778 into crate-crypto:master Jul 16, 2024
17 of 18 checks passed
@jtraglia jtraglia deleted the verify-cell-kzg-proof-batch-bench branch July 16, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants