fix: Revert "fix: ignore go.mod by default"

[epage]

This reverts commit 4eeb460.

Original PR: #684

Original Issue: #683

This didn't cause go.mod to be ignored instead it caused it to not be counted as go code.
However, go.mod and go.work are similar file types and both are more of package specifications than lock files or other machine-only content.

See #1363

[coveralls]

Pull Request Test Coverage Report for Build 17303202645

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 20.434%

---

Totals
Change from base Build 17212446462:	0.0%
Covered Lines:	574
Relevant Lines:	2809

---

💛 - Coveralls

[ccoVeille]

Nitpicking: I would fix the typo in commit message

ignoredinstead should be ignored instead

[ccoVeille]

Is there a need to add go.sum and go.work.sum to ignored files ?

[epage]

Is there a need to add go.sum and go.work.sum to ignored files ?

Those are in the lockfile type which is not checked

[ccoVeille]

This change equivalent to add locally add go.mod and go.work to extends glob for type go, right?

Because when I try it locally it reports typos for go.mod files

Try this one

https://github.com/noborus/ov/blob/master/go.mod

Maybe I'm wrong, but I prefer to ask.

[epage]

Yes, this makes *.go, go.mod, and go.work all the same file type. Unless you have some go-specific config in place, this shouldn't really change much.

[ccoVeille]

Is there a need to add go.sum and go.work.sum to ignored files ?

Those are in the lockfile type which is not checked

Indeed. I didn't see it.

Yes, this makes *.go, go.mod, and go.work all the same file type. Unless you have some go-specific config in place, this shouldn't really change much.

Then, it reports errors.

I feel like in .go files everything is checked, and not only comments.

But we expect something different for go.mod and go.work where we only need to check comment.

Please try with the go.mod file I provided

[epage]

I feel like in .go files everything is checked, and not only comments.

typos works off of all file contents and has no knowledge of individual file types grammars, including comments.

[ccoVeille]

I feel like in .go files everything is checked, and not only comments.

typos works off of all file contents and has no knowledge of individual file types grammars, including comments.

Oh OK. Then I would exclude go.mod and go.work totally.

That's what I did for many projects.

[ccoVeille]

I just saw your comment here.

this just becomes a hash detection issue.
Originally posted by @epage in #1363 (comment)

You are right. Let's continue the discussion in #1363

• Typos claims a typo in a version number in a go.mod file #1363 (comment)