`typ` as Typst extension

[mo8it]

Description

typ -> typo from #1221 (comment) should be reverted since typ is the extension of Typst files.

typ could also be type, so the current state is problematic anyway.

[epage]

This opens up a bigger topic, like #1149:

In the past, we accidentally let words be corrected that shouldn't, leading to allowed.csv. Seeing enough english words go through that, we added english.csv.

What I'm wondering is what should be our bar for [file extensions] being included and if we should mass import them. ...

[xxchan]

We have massive usage of typ as type :(

e.g.,

error: `typ` should be `typo`
  --> ./src/common/src/row/owned_row.rs:168:13
    |
168 |         for typ in self.data_types() {
    |             ^^^
    |
error: `typ` should be `typo`
  --> ./src/expr/core/src/window_function/kind.rs:48:29
   |
48 |             PbType::General(typ) => match PbGeneralType::try_from(*typ) {
   |                             ^^^
   |
error: `typ` should be `typo`
  --> ./src/tests/sqlsmith/src/sql_gen/expr.rs:40:39
   |
40 |     pub(crate) fn gen_expr(&mut self, typ: &DataType, context: SqlGeneratorContext) -> Expr {
   |                                       ^^^
   |

[jamesbraza]

Coming from #1264:

for typ in (TokenTypes.THOUGHT, TokenTypes.ANSWER)

I think typ is fine (short for "type"), whereas typo is the wrong correction. At least I think an autofix here should not be considered safe

[epage]

I'm fine with adding type as a second correction.

What would be useful is to explore how often typ is used as an abbreviation in programming.

[BenjaminBrienen]

If you deliberately misspell "type" as "typ" instead of using "r#type" or the like, then I think you should just add it to your typos.toml. I find the correction useful!

[adamchainz]

I have also just encountered a lot of typ used as an abbreviation of type.

[kemingy]

I also use typ in the codebase since type is a soft keyword in Python.

• ref: https://docs.python.org/3.14/reference/lexical_analysis.html#soft-keywords

[BenjaminBrienen]

I also use typ in the codebase since type is a soft keyword in Python.

• ref: https://docs.python.org/3.14/reference/lexical_analysis.html#soft-keywords

https://peps.python.org/pep-0008/

single_trailing_underscore_: used by convention to avoid conflicts with Python keyword, e.g.

If a function argument's name clashes with a reserved keyword, it is generally better to append a single trailing underscore rather than use an abbreviation or spelling corruption. Thus class_ is better than clss. (Perhaps better is to avoid such clashes by using a synonym.)

If your public attribute name collides with a reserved keyword, append a single trailing underscore to your attribute name. This is preferable to an abbreviation or corrupted spelling.

[Gabgobie]

Since this issue was originally opened due to typ being the file extension for Typst, wouldn't it be feasible to consider typ correct if it is right after a ".", i. e. .typ? This would leave the correctness of typ in code up for debate but could satisfy this issue.