Fix Daikin312 missing leader pulse - #2270
Open
naoki-mizuno wants to merge 1 commit into
Open
Conversation
naoki-mizuno
marked this pull request as draft
June 22, 2026 05:26
Contributor
Author
|
Need to fix the failing tests. It seems the |
naoki-mizuno
force-pushed
the
fix/daikin-312-leader-pulse
branch
from
June 22, 2026 10:49
043c3cd to
5098b68
Compare
Header previously had a 5-bit preamble; however, captured data of an ARC472A43 remote shows leader pulse, similar to Daikin2 format. This leads to Daikin2 and Daikin312 sharing identical structure, thus, they are now distinguished by checking the state[4] byte (0x01 = Daikin2, 0x02 = Daikin312). Test case for real example has been updated with data captured using a Moes UFO-R11 IR blaster/receiver. This receiver encodes data in Tuya format, which has been converted to marks/spaces using the Sensus converter tool (https://pasthev.github.io/sensus/). Assisted-by: Claude (Anthropic)
naoki-mizuno
force-pushed
the
fix/daikin-312-leader-pulse
branch
from
June 22, 2026 11:15
5098b68 to
787148b
Compare
naoki-mizuno
marked this pull request as ready for review
June 22, 2026 11:21
Contributor
Author
|
As described in the updated commit message, I updated the test case with the signal that I captured using a ARC472A43 remote. The original test data did not have this and instead had a 5-bit preamble. All data that I captured had the leader pulse, so I’m not sure why the original data didn’t have it included. Maybe it was catching the trailing zeros of the leader? Notes:
Included as the Captured when AC was in cool mode. Temperature button (down) was pressed. Captured when AC was in cool mode. Off button was pressed. |
Collaborator
|
Does this change make the original captures to being unknown? That would potentially be a breaking change. |
Contributor
Author
|
Thanks for taking a look.
Not necessarily. As far as I tested, it was only the leader pulse that was missing from the original captures and all other parts were working. The IR signal based on the original captures are accepted by the AC (only issue is that the AC stops responding to signals after a few hours of silence). This is the reason why I don’t think my unit is using a different protocol. Still, it would be nice to get some help verifying that this (and perhaps also #2268) doesn’t break anything. Pinging @carl09 and @AntonWert who were involved in #2246 and #1829 for adding Daikin 312 protocol support. As a side note, I’ve been using IR signals generated with the changes in this PR and also #2268 for over a month now and had no issues. |
Contributor
|
I tested out your changes on my AC units and they work perfectly. Thank you for your effort on fixing this up |
Contributor
Author
|
@carl09 Thank you very much for testing it out! I appreciate your help. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR: Leader pulse was missing from the IR command, resulting in the AC ignoring commands after 5 minutes of off period.
While testing out the changes in #2268 I noticed that most of the times the commands were received, but if I left the AC off for 5 minutes or longer it would ignore the commands. If I use the remote to turn on the AC, it would accept all subsequent commands (even if I turn it off briefly). I’m not sure why it stops receiving commands after that period (clock going out of sync? IR receiver going into deep-sleep?) but it took me a while and a bit of signal comparison to figure it out.