-
Notifications
You must be signed in to change notification settings - Fork 833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for Bluestar Heavy AC #2120
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work so far, there is some more work that's needs to be done before it could be merged, some of them matches with linter issues, also the supported section, at least we need some model info.
Tests needs to be revisited. Could you also post the codes you get as message from lowest to highest temp to verify endiness of protocol
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First off, congrats and well done adding a protocol successful! Looks good.
Sorry about the mostly nitpicking comments and feedback. All of it is mostly minor, but it cleans up the code a lot.
Looking forward to the changes so we can merge it.
@NiKiZe @crankyoldgit |
Could you please post the codes you get here (the hex 0x part) as a list from lowest to highest temp. I tried to check your sheet but it didnt seem to be in order, so I would like to see the actual hex instead. It might also be good to loop thru fan speeds to verify which bits are actually the checksums. |
Hey @harshbhosale01 If you flip the bits , you'll find the temperature increases by one for each degree. const uint16_t kBluestarHeavyOneSpace = 572;
const uint16_t kBluestarHeavyZeroSpace = 1548; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two more nitpicks to go. And the swap of zeros and ones per other comments.
Otherwise, it now looks good to me. Thanks for doing this!
Oh okay, I'll do that but as asked by @NiKiZe. I've also gathered the HEX codes from Lowest to Highest temp. Please find it in the following link. |
Once the bits are inverted, this will change, but it's still good data to keep here.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Before we merge, can you please check if the temperature range increases sequentually now? It should,
Yes @crankyoldgit |
Awesome! |
Added support for Bluestar Heavy AC (crankyoldgit#2120)
In the following PR, support was added for Bluestar heavy AC. I don't have information about the model of AC but the following is a picture of the remote.
Changes were made according to the given doc in the wiki section [Adding support for a new IR protocol]. I wasn't able to figure out how to begin writing the test code for my model, so I have dropped that part. Else everything works fine from my end. I've tested the ir_sendBluestarHeavy function with esp8266 which works well. Also, the run_tests went well on my device.
I've tried to gather IR codes for Bluestar Heavy AC and attached them in the following sheet link.
In case you need raw IR data, here it is
`IRrecvDump is now running and waiting for IR input on Pin 4
Timestamp : 000001.564
Library : v2.8.6
Protocol : UNKNOWN
Code : 0x3F7789A6 (106 Bits)
uint16_t rawData[211] = {5000, 5060, 478, 1542, 476, 1542, 478, 468, 558, 1542, 476, 500, 526, 1540, 478, 548, 478, 1542, 476, 1542, 478, 1542, 476, 1544, 476, 1542, 476, 1544, 476, 1542, 478, 1542, 476, 474, 552, 1542, 478, 1542, 476, 548, 510, 1510, 476, 548, 478, 1542, 476, 1542, 476, 1544, 474, 550, 478, 1542, 478, 548, 476, 1542, 476, 548, 484, 1536, 476, 1542, 450, 1570, 476, 1542, 476, 1544, 472, 1546, 476, 1544, 478, 1540, 476, 550, 476, 1542, 450, 576, 476, 548, 480, 1540, 476, 550, 476, 1542, 476, 1542, 478, 1542, 476, 1542, 508, 1512, 476, 1542, 478, 1540, 452, 1566, 478, 1540, 478, 1540, 478, 528, 498, 1542, 478, 528, 496, 530, 498, 1540, 452, 554, 496, 1542, 476, 1540, 482, 1518, 496, 1522, 494, 1544, 478, 1522, 496, 1522, 496, 1544, 476, 1542, 476, 1542, 482, 1536, 454, 1566, 478, 1522, 498, 546, 476, 1542, 476, 1542, 476, 1542, 476, 1544, 474, 1544, 478, 1540, 476, 1542, 474, 552, 472, 1544, 448, 1570, 474, 552, 474, 552, 472, 1548, 472, 556, 470, 554, 446, 1574, 468, 1550, 472, 1548, 442, 1576, 466, 1552, 442, 1576, 466, 558, 468, 1552, 466, 1554, 464, 1566, 454, 560, 464, 1554, 464, 1578, 442, 1578, 440, 560, 466, 560, 4966}; // UNKNOWN 3F7789A6
`
If any more support from my end is needed, I would be more than happy to provide it. I've written a blog on how I worked with learning IR using your library, I'm not an electronic expert. So please don't expect much from this blog. You can read it using this link.