ch: add app tests #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mubangizi
force-pushed
the
ft-test-service
branch
12 times, most recently
from
39cb360 to
1a6fc29
Compare
Mubangizi
force-pushed
the
ft-test-service
branch
from
1a6fc29 to
211caf8
Compare
Mubangizi
requested changes
Jan 22, 2025
Contributor
Mubangizi
left a comment
Mubangizi
left a comment
There was a problem hiding this comment.
Great work, just a few issues to address
Dockerfile
Outdated
|
|
||
| WORKDIR /app | ||
|
|
||
| ARG FASTAPI_ENV='development' |
Contributor
There was a problem hiding this comment.
Remove this, because we use this docker file in staging and prod deployments
docker-compose.yml
Outdated
| networks: | ||
| cranecloud: | ||
| external: true | ||
| external: false |
|
|
||
| test:build-testing-image ## Run tests | ||
| @ ${INFO} "Running tests" | ||
| @ docker compose -f $(DOCKER_DEV_COMPOSE_FILE) exec app-logger poetry run pytest --cov=. --cov-report=term-missing |
Contributor
There was a problem hiding this comment.
Create the external network at this point
Contributor
Author
|
@Mubangizi this is done |
Mubangizi
approved these changes
Jan 23, 2025
Contributor
Mubangizi
left a comment
Mubangizi
left a comment
There was a problem hiding this comment.
Great work @khalifan-kfan
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does?
Adds initial testing to the application
How to run it.
Run
make test