Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Pitch Register #34

Merged
merged 1 commit into from
Jun 23, 2024
Merged

Add Pitch Register #34

merged 1 commit into from
Jun 23, 2024

Conversation

craigthomas
Copy link
Owner

This PR adds a pitch register to the CPU, as well as performs a playback rate calculation for the audio buffer. A new instruction for Fx3A is added called load_pitch that loads a pitch value from a V register into the pitch register. The new playback rate is calculated once the register is loaded with a new pitch. Unit tests added to cover new conditions. This PR closes #31

Copy link

codecov bot commented Jun 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.27%. Comparing base (52925f3) to head (1da3918).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #34      +/-   ##
==========================================
+ Coverage   90.08%   90.27%   +0.18%     
==========================================
  Files           4        4              
  Lines         464      473       +9     
==========================================
+ Hits          418      427       +9     
  Misses         46       46              
Files Coverage Δ
chip8/cpu.py 97.33% <100.00%> (+0.06%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dab0e5e...1da3918. Read the comment docs.

@craigthomas craigthomas merged commit 2e64371 into main Jun 23, 2024
3 checks passed
@craigthomas craigthomas deleted the pitch-register branch June 23, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Pitch Register for Audio Playback
1 participant