Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default the interpreter to set memory size to 64K. #33

Merged
merged 1 commit into from
Jun 23, 2024

Conversation

craigthomas
Copy link
Owner

@craigthomas craigthomas commented Jun 23, 2024

This PR changes the emulator to use a 64K memory space by default instead of the 4K memory space as defined by the original Chip8 language specification. This memory size can be changed by using the --mem_space flag if desired. Unit test added to catch new condition. This PR closes #24

Copy link

codecov bot commented Jun 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.08%. Comparing base (a0f7a93) to head (52925f3).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #33      +/-   ##
==========================================
- Coverage   90.10%   90.08%   -0.03%     
==========================================
  Files           4        4              
  Lines         465      464       -1     
==========================================
- Hits          419      418       -1     
  Misses         46       46              
Files Coverage Δ
chip8/cpu.py 97.26% <ø> (-0.01%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cfcee8...52925f3. Read the comment docs.

@craigthomas craigthomas merged commit dab0e5e into main Jun 23, 2024
3 checks passed
@craigthomas craigthomas deleted the default-64k-mem branch June 23, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default Memory Size to 64K
1 participant