Remove use of Vector #50
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using Vector is not required anymore since Dynarray was added to Stdlib in OCaml 5.2.0
That being said, I understand that this means Progress is only compatible with 5.2 and beyond, so I'm not convinced it's a good idea to merge this.
I made it because lem exposes a Vector module and that clashes with the Vector library... And modifying lem is a much harder task than modifying Progress. I did ask the maintainers of lem to hide the export to avoid that issue, but in the meantime I have my fork of Progress.
Still, I thought I'd open the PR and let you make that decision :)