Skip to content

Remove use of Vector #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove use of Vector #50

wants to merge 1 commit into from

Conversation

giltho
Copy link

@giltho giltho commented Jun 3, 2025

Using Vector is not required anymore since Dynarray was added to Stdlib in OCaml 5.2.0

That being said, I understand that this means Progress is only compatible with 5.2 and beyond, so I'm not convinced it's a good idea to merge this.
I made it because lem exposes a Vector module and that clashes with the Vector library... And modifying lem is a much harder task than modifying Progress. I did ask the maintainers of lem to hide the export to avoid that issue, but in the meantime I have my fork of Progress.

Still, I thought I'd open the PR and let you make that decision :)

Signed-off-by: Sacha-Élie Ayoun <sachaayoun@gmail.com>
@giltho
Copy link
Author

giltho commented Jun 3, 2025

(That being said, going to OCaml 5 would give a good occasion to address #46 and to give an effect-handler interface to Progress, it's a perfect use case, instead of having to carry around the progress function)

@dinosaure
Copy link
Collaborator

In my opinion, forcing progress to require only OCaml 5.2 is too restrictive for people who use progress and want this library to remain available for 4.14 (at least).

I made it because lem exposes a Vector module and that clashes with the Vector library... And modifying lem is a much harder task than modifying Progress. I did ask the maintainers of lem to hide the export to avoid that issue, but in the meantime I have my fork of Progress.

Another solution could be to rename the Vector module to progress - this module is not intended to be exported.

@giltho
Copy link
Author

giltho commented Jun 3, 2025

I think the issue stems from the existence of Vector in my opam switch as a dependency of something I import, I don't think it's exported by Progress at all.

But yeah, I agree that it's a bit restrictive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants