Fix issue where adding a message stream would return error from API #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ince it needs to be string format
remipelhate
requested changes
May 10, 2022
There was a problem hiding this comment.
Hmm that does not comply with their SDK though (as reported by PHPStan 👉🏻 https://github.com/craftzing/laravel-postmark-notification-channel/runs/6369415840?check_suite_focus=true).
I presume the SDK handles this internally, in which case it might be better to follow the SDK. Or did you encounter a specific issue with the current implementation?
|
Hmm, weird! Dan is dat volgens mij ook een fout in SDK 🤔 Want ik had messagestreams gebruikt in Royal Botania en daar kreeg ik een JSON error als ik het als array doorstuurde, maar als het een string was werkte het wel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the api docs the message streams param in de template message needs to be in string format. Otherwise the api will return an error message