-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remark@next (13) #2
Comments
Martii
added a commit
to Martii/OpenUserJS.org
that referenced
this issue
Oct 19, 2020
* Please read their CHANGELOGs * *remark* , *remark-strip-html* , and *strip-markdown* are on hold since they are interdependent and needs in-depth retesting. See craftzdog/remark-strip-html#2 , remarkjs/remark#536 , and remarkjs/strip-markdown@0ceb371#diff-5a831ea67cf5cf8703b0de46901ab25bd191f56b320053be9332d9a3b0d01d15 * *sanitize-html* CHANGELOG at https://github.com/apostrophecms/sanitize-html/blob/main/CHANGELOG.md#200-2020-09-23 . We don't DOM insert , pro *node* is acceptable, and we override `allowedTags` to usually match GH. * *spdx-license-ids* is going to take some time as a bunch of new ones have been added and need to be cross-checked/restricted. On hold. * *moment* is in "maintenance mode" and deprecated. Will address this much later. * Delete op retested
Martii
added a commit
to OpenUserJS/OpenUserJS.org
that referenced
this issue
Oct 19, 2020
* Please read their CHANGELOGs * *remark* , *remark-strip-html* , and *strip-markdown* are on hold since they are interdependent and needs in-depth retesting. See craftzdog/remark-strip-html#2 , remarkjs/remark#536 , and remarkjs/strip-markdown@0ceb371#diff-5a831ea67cf5cf8703b0de46901ab25bd191f56b320053be9332d9a3b0d01d15 * *sanitize-html* CHANGELOG at https://github.com/apostrophecms/sanitize-html/blob/main/CHANGELOG.md#200-2020-09-23 . We don't DOM insert , pro *node* is acceptable, and we override `allowedTags` to usually match GH. * *spdx-license-ids* is going to take some time as a bunch of new ones have been added and need to be cross-checked/restricted. On hold. * *moment* is in "maintenance mode" and deprecated. Will address this much later. * Delete op retested Auto-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi!
remark is switching to a new parser internally (micromark, see
remarkjs/remark#536
for more info).From a quick glance at the code, it seems this plugin should be fine. However, it would be good to check that in the future (there is
13.0.0-alpha.0
published now, and one or two more will come before the release)Btw, I suggest using unist-util-visit and removing HTML with that. See https://unifiedjs.com/learn/recipe/remove-node/ for more info!
The text was updated successfully, but these errors were encountered: