[5.x]: Cart performance slow with 100 shipping rules (N+1 queries)

[lenvanessen]

What happened?

Description

Every time the cart is updated, Craft Commerce evaluates ALL shipping rules to determine which ones apply, and it fetches the category conditions for each rule individually causing n+1 queries and sluggish add to cart problem).

Steps to reproduce

1. Add many shipping rules
2. Check the queries executed by adding a item to the cart

Expected behavior

Smarter evualition, maybe not on add to cart, or filtering relevant rules by getting them in bulk

Actual behavior

Slow, +1second add to cart

Craft CMS version

5.8.23

Craft Commerce version

5.5.2

PHP version

No response

Operating system and version

No response

Database type and version

No response

Image driver and version

No response

Installed plugins and versions

[linear]

COM-522

[lukeholder]

Hi, Thanks for this info!

I have gone ahead and added eager loading to shipping categories to the rules and I see massive performance improvements.

This introduces new functionality and methods so it is slated to be included in 5.6

#4221

We will update this issue once the release is out. Thanks!