[5.x]: Adding a transaction which completes an order does not respect the `suppress emails` toggle

[MatthiasBrodelet]

What happened?

Description

Context:

• Our client has a webshop with prices that change every minute (gold and silver).
• The Open status automatically sends an order confirmation email.
• I have added custom code so that an order cannot be completed unless there is a transaction defined in the order

When the client creates a manual order in the CP they often need to manually adjust the prices to what they negotiated with the client. This is only possible AFTER the order has been completed. This is why they do not want the client to receive an automatic order confirmation mail when creating a manual order.
That is why we always enable the Suppress emails lightswitch when adding a transaction.
However, it seems like that option is completely ignored.

I could work around it by using an event to block the mail only when the order has been created in the CP but it feels like a dirty trick while the current behaviour feels like a bug.

Steps to reproduce

1. Create a manual order
2. Enable the suppress emails lightswitch
3. Add a transaction that converts the cart to an order

Expected behavior

Since this action triggers a status change we would expect to be able to suppress this email.

Actual behavior

The confirmation mail is not suppressed.

Craft CMS version

5.9.2

Craft Commerce version

5.5.2

PHP version

8.2

Operating system and version

No response

Database type and version

No response

Image driver and version

No response

Installed plugins and versions

[linear]

COM-519

[lukeholder]

Thanks for the report. The suppress option was added for when an order is manually completed but the use of the button above it.

It does not suppress all emails that could be triggered for the order.

We will discuss whether this is a bug or whether we need to add another feature for other types of suppression.

I will return and report once we decide the path to take.

[MatthiasBrodelet]

@lukeholder Thanks. I figured as much since the suppress option is positioned a bit awkward when performing this action.
Another suppress toggle in the payment modal only when the order has not yet been completed might be more logical.